Repository navigation
feat(settings): add observability.log_retention_days - #8383
Merged
Merged
Conversation
Adds an ObservabilitySettings group with log_retention_days: how many days after an attempt ends its task logs stay visible. 0 or unset leaves it to the server, which may also cap how high it can be set. The runs settings service merges it like the other scalar settings and rejects a negative value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
…settings-log-retention-days
pmahindrakar-oss
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Organizations need to choose how long task logs stay visible, and a server may need to cap that, for example by plan. Settings had no field for it.
What changes were proposed in this pull request?
ObservabilitySettingsgroup withInt64Setting log_retention_days, added toSettingsasobservability(field 10). This is the number of days after an attempt ends that its logs stay visible.0or unset leaves it to the server, which may also cap how high it can be set.INVALID_ARGUMENT.The field only declares the setting; this PR doesn't hide or delete any logs. A server decides how to apply it.
How was this patch tested?
TestMergeObservabilitySettings: the most specific scope wins, and nothing stored resolves to nil.TestMergeSettingsHandlesEveryFieldnow includesobservability.TestValidateLogRetentionDays: nil, unset, 0, positive and negative values.go test ./runs/...passes, andbuf lintis clean.Labels
Check all the applicable boxes