Repository navigation
Conversation
Signed-off-by: Yuteng Chen <a08h0283@gmail.com>
…askresource fields Signed-off-by: Yuteng Chen <a08h0283@gmail.com>
…fault_accelerator Signed-off-by: Yuteng Chen <a08h0283@gmail.com>
|
Tested this on Linux with an NVIDIA GPU (RTX 5080 Laptop, 16 GB), using the GPU devbox built from this branch (0da7eba, Project settings (flytesnacks / development): task_resource.max.gpu: "1"
task_resource.default_accelerator: nvidia-l4The node is labeled
So once the node label matches, the pod does get scheduled onto the GPU node and sees the GPU. The nodeAffinity on the One note: I only set |
0yukali0
left a comment
There was a problem hiding this comment.
- Tasks get the settings min as their default resource request, clamped so it never exceeds max, and max caps both the task's requests and limits.
- When the settings set a min for ephemeral storage, a task that doesn't set storage gets that value as its request and limit.
- The settings' default_accelerator is applied to tasks that request GPUs but don't name an accelerator.
| } | ||
| } | ||
|
|
||
| func newTaskResourceDefaults(tr *settings.TaskResourceSettings) *task.TaskResourceDefaults { |
There was a problem hiding this comment.
Setting providing min and max resources (called res1 and res2) sets the pod spec.resource.
- Treat the res2 as big one and set the limit with it.
- Set the request with res1 if res1 < res2. otherwise, set it with res2.
| }, | ||
| }, | ||
| { | ||
| name: "INHERIT and UNSET dimensions is ignored", |
There was a problem hiding this comment.
resolveSettings handles the merge of setting from the hierarchy including org, domain and project.
INHERIT(default) and UNSET(~unset) shows up in some scenarios.
Tracking issue
Closed #8316
Why are the changes needed?
Project task_resource settings are resolved but never applied. To give admins resource guardrails,
the settings need to be turned into default task resources and carried through run creation, the
action, and the pod, so that tasks get default values and are capped at the configured max.
What changes were proposed in this pull request?
Child actions inherit them from their parent.
How was this patch tested?
make devbox-build && make devbox-run APPLE_SILICON=True # I tested on the Mac.
[Optional] flyte get settings --domain development --project flytesnacks
res.yaml
Tasks
2.1 no resource setting adopts min resource in setting then set the resource with min resources.
Labels
Setup process
Screenshots
Check all the applicable boxes