Repository navigation
Conversation
Add a flyteidl2.common.allowed_when_restricted method option for RPCs that have side effects but stay open for an org restricted to read-only: stopping work (AbortRun, AbortAction, DeleteTriggers, app Delete) and work already running (ActionsService Update/Signal/Enqueue, SignalEvent, TrackedRunService ReportActions, app Lease/UpdateStatus). A deployment that restricts an org refuses every other RPC with side effects. Enqueue stays open for child actions only; a root action starts a new run. Mark reads that declared no idempotency level as NO_SIDE_EFFECTS: CreateDownloadLink, GetSecret, UserInfo, and the connector reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Adam Brock <adam@union.ai>
|
This PR was flagged by our automated quality checks. If you're a genuine We appreciate your contribution and apologize if this is a false positive! |
EngHabu
reviewed
Nov 6, 2026
Signed-off-by: Adam Brock <adam@union.ai>
Running work reports its action events through Record, like ActionsService.Update and TrackedRunService.ReportActions, which are already allowed. Without it, a deployment restricting an org would refuse progress and terminal-event reports for work already running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H6679xdozKcpp5NqHwjgEa Signed-off-by: Adam Brock <adam@union.ai>
Contributor
Author
|
Closing: Union is enforcing its billing lockout in its own authorizer instead, so flyteidl2 doesn't need the allowed_when_restricted option. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A deployment can restrict an organization to read-only, for example when its billing access is disabled for an unpaid invoice. It then refuses every RPC with side effects except a small set that has to stay open: stopping work, and work that is already running reporting its progress. The deployment reads that set from the proto definitions, so the RPCs defined in flyteidl2 need a way to declare it. Some reads also declare no idempotency level, so they are treated as writes.
What changes were proposed in this pull request?
flyteidl2/common/rpc_options.proto, which defines the method optionallowed_when_restricted(field 50101).RunServiceAbortRun,AbortAction,SignalEventTrackedRunServiceAbortRun,ReportActionsActionsServiceEnqueue,Update,Abort,Signal. The comment onEnqueuenotes that only child actions are served for a restricted org, since a root action starts a new run.AppServiceDelete,Lease,UpdateStatusTriggerServiceDeleteTriggersidempotency_level = NO_SIDE_EFFECTSon reads that declared no level:DataProxyService/CreateDownloadLink,SecretService/GetSecret,IdentityService/UserInfo, and theAsyncConnectorServiceandConnectorMetadataServicereads.Nothing in this repository reads the new option, so behavior here is unchanged. The
NO_SIDE_EFFECTSdeclarations let connect clients send those RPCs as HTTP GET requests.How was this patch tested?
buf formatandbuf lintpass, and the generated Go builds.🤖 Generated with Claude Code