Skip to content

feat(settings): add SecuritySettings.kubernetes_namespace - #8311

Merged
EngHabu merged 1 commit into
mainfrom
haytham/settings-kubernetes-namespace
Nov 3, 2026
Merged

EngHabu merged 1 commit into
mainfrom
haytham/settings-kubernetes-namespace

Conversation

@EngHabu

@EngHabu EngHabu commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

A deployment may want a project's task pods and apps to run in a namespace other than the one it derives from the project and domain, for example a dedicated namespace an admin prepared. Settings already choose a project's queue and service account, scoped org > domain > project. This adds the namespace to the same place, so an admin can set it for the whole org, a domain, or one project-domain.

What changes were proposed in this pull request?

  • New field: SecuritySettings.kubernetes_namespace = 2, a StringSetting with the description "Kubernetes namespace that task pods and apps run in". It sits next to service_account.
  • Merging: mergeSecuritySettings resolves it across the level chain like service_account. A security group holding only the namespace still resolves.
  • Generated code: regenerated for Go (with validators), Python, Rust and TypeScript.

The runs service only stores and resolves the setting; it does not act on it. A server that does may restrict the allowed values and who may set them.

How was this patch tested?

  • New TestMergeSettings_KubernetesNamespace: an org value is inherited, a project value overrides it at project level, and a namespace-only group resolves.
  • Existing TestMergeSettingsHandlesEveryField passes, so every settings field is still merged.
  • make buf outputs were regenerated for every language.

Labels

  • added

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

🤖 Generated with Claude Code

A setting for the Kubernetes namespace task pods and apps run in, resolved
org > domain > project like service_account. A server may restrict the
allowed values and who may set it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EuLd1BpsMEzMwhnd2bYhsK
Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
@github-actions github-actions Bot added the flyte2 label Nov 3, 2026
@EngHabu EngHabu added the added Merged changes that add new functionality label Nov 3, 2026
@EngHabu
EngHabu merged commit 05ebd13 into main Nov 3, 2026
26 of 29 checks passed
@EngHabu
EngHabu deleted the haytham/settings-kubernetes-namespace branch November 3, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added Merged changes that add new functionality flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants