Repository navigation
feat(settings): add SecuritySettings.kubernetes_namespace - #8311
Merged
Merged
Conversation
A setting for the Kubernetes namespace task pods and apps run in, resolved org > domain > project like service_account. A server may restrict the allowed values and who may set it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuLd1BpsMEzMwhnd2bYhsK Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
pmahindrakar-oss
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A deployment may want a project's task pods and apps to run in a namespace other than the one it derives from the project and domain, for example a dedicated namespace an admin prepared. Settings already choose a project's queue and service account, scoped org > domain > project. This adds the namespace to the same place, so an admin can set it for the whole org, a domain, or one project-domain.
What changes were proposed in this pull request?
SecuritySettings.kubernetes_namespace = 2, aStringSettingwith the description "Kubernetes namespace that task pods and apps run in". It sits next toservice_account.mergeSecuritySettingsresolves it across the level chain likeservice_account. A security group holding only the namespace still resolves.The runs service only stores and resolves the setting; it does not act on it. A server that does may restrict the allowed values and who may set them.
How was this patch tested?
TestMergeSettings_KubernetesNamespace: an org value is inherited, a project value overrides it at project level, and a namespace-only group resolves.TestMergeSettingsHandlesEveryFieldpasses, so every settings field is still merged.make bufoutputs were regenerated for every language.Labels
Check all the applicable boxes
🤖 Generated with Claude Code