Repository navigation
feat: server-selected Kubernetes namespace in run and app specs - #8300
Merged
Merged
Conversation
Regenerating on CI (check-generate) reproduces main's validate_pb.ts; the earlier regeneration here had changed one line of it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuLd1BpsMEzMwhnd2bYhsK Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
check-generate's make buf adds the field to gen/rust/src/flyteidl2.task.rs, which the earlier Rust regeneration had missed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuLd1BpsMEzMwhnd2bYhsK Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
…d on The run and app fields are the metadata message, of which the namespace is the one field today. An app's namespace is set when it is created or turned on and is fixed only while it runs, so a binding changed while it is off applies at its next start. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuLd1BpsMEzMwhnd2bYhsK Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
2 of 3 tasks
pingsutw
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A control plane may need to choose the Kubernetes namespace a run's or an app's pods are created in, for example to place a project's workloads in a dedicated namespace. Once chosen, the namespace must stay fixed while the workload runs:
That needs a field where the server records the namespace it selected, so the choice persists with the run or app spec and reaches every action.
What changes were proposed in this pull request?
flyteidl2.common.K8sMetadata(flyteidl2/common/kubernetes.proto): Kubernetes metadata the server sets for a run or app. Its one field,namespace, requiresmin_len = 1when the message is present.RunSpec.k8s_metadata = 21: set when the run is created and fixed afterwards; it applies to every action and finalizer.app.Spec.k8s_metadata = 17: set when the app is created or turned on, and fixed while it runs.The field is server-owned: a server should ignore any value a client sends and set it itself.
How was this patch tested?
make bufoutputs regenerated for every language;check-generatepasses.Labels
Check all the applicable boxes
🤖 Generated with Claude Code