Repository navigation
IDL: action input and code overrides and a fork marker for recovery runs #8234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5b92457
3374208
ec2ac72
d7d8259
6da9166
046033b
9730bf9
4407aed
ebcd373
3eef58e
8815e81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,15 @@ message Recover { | |
| // subtree). A listed condition action re-pauses and waits for a new signal. | ||
| // Unknown names are ignored. | ||
| repeated string force_rerun_actions = 1 [(buf.validate.field).repeated.items.string.min_len = 1]; | ||
|
|
||
| // Field numbers of the removed action_overrides and implied_rerun_actions. | ||
| reserved 2, 3; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we dont need to reserve. this was never merged |
||
|
|
||
| // Marks this recovery run as a fork: it reuses the run being recovered but runs | ||
| // changed code or inputs, rather than retrying it unchanged. Set by the client | ||
| // that creates the fork. Informational: it does not change how the run is | ||
| // recovered. | ||
| bool fork = 4; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: "clears it on a run that is not a recovery". The Union backend rejects any
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 4407aed: the comment no longer says the server clears it. |
||
| } | ||
|
|
||
| // TaskSpecSource records how a run's task spec was provided at creation time, so | ||
|
|
||
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this passed from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes from the client that creates the fork. Today that's the Union console's Fork form; the SDK can do the same through
custom_context. The control plane never parses it.Write (fork client, at CreateRun):
It uploads each edited action's partial
Inputs(and any replacement code bundle.tar.gz) to the data plane with the regular upload path.It builds an
ActionOverridesData(input_uris,code_bundles,ancestor_actions), serializes it, and uploads it as one more file.It sends
CreateRunwith aRECOVERrelation:Inputs.contextunder_u_action_overridesRunSpec.recover.force_rerun_actionsConsole code:
clientsv2/src/components/LaunchForm/fork/useForkSubmit.tsandbuildLaunchRunSubmitPayload.tsin unionai/cloud#19498.Carry (backend, unchanged):
Inputs.contextis already inherited by every action a parent spawns, so the URI reaches each action of the run with no new plumbing. The backend only usesforce_rerun_actions, to skip recovery for those actions. It never opens the overrides file.Read (SDK remote controller, in the parent's pod): when a parent submits a sub-action, it reads
_u_action_overridesfrom its task context. If the child's name is in the file, it loads the override inputs and overlays them by name on the inputs it computed, and/or swaps in the replacement code bundle. Then it uploads inputs and enqueues as usual. See_action_overrides/_input_overrides.pyin flyteorg/flyte-sdk#1708.The data stays in the data plane like any other
input_uri; the control plane only sees a string in the context.