Skip to content

pipeline: outputs: cloudwatch: Add StorageResolution Support#1691

Open
devin-andrenam wants to merge 5 commits into
fluent:masterfrom
devin-andrenam:devin/update-docs-storage-resolution-emf
Open

pipeline: outputs: cloudwatch: Add StorageResolution Support#1691
devin-andrenam wants to merge 5 commits into
fluent:masterfrom
devin-andrenam:devin/update-docs-storage-resolution-emf

Conversation

@devin-andrenam
Copy link
Copy Markdown

Documentation update in association with according PR to fluent bit.

@devin-andrenam devin-andrenam requested review from a team as code owners May 29, 2025 03:23
Signed-off-by: Devin Stafford <devin@andrenam.com>
Copy link
Copy Markdown
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic change. A @fluent/fluent-bit-maintainers should doublecheck the definition for technical accuracy, but I'm otherwise ok with this.

Comment thread pipeline/outputs/cloudwatch.md Outdated
Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 21, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

@devin-andrenam while waiting on the code PR changes fluent/fluent-bit#10398 you need to make, would you please fix the conflicts here so I'm ready to merge your docs update when we can?

Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@esmerel
Copy link
Copy Markdown
Contributor

esmerel commented Oct 21, 2025

Conflict was due to formatting changes for style. I reverified so the submitter doesn't need to.

@esmerel esmerel removed conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes labels Oct 21, 2025
@patrick-stephens
Copy link
Copy Markdown
Contributor

There are on changes?

Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@esmerel
Copy link
Copy Markdown
Contributor

esmerel commented Oct 21, 2025

Appears I overwrote the change fixing the conflict, I corrected it. I was afraid I'd done that at least once.

@eschabell eschabell added 4.2.1 conflict Waiting on conflict to be resolved by contributor and removed 4.2.1 labels Dec 3, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

@devin-andrenam there are still conflicts here that need to be addressed, not sure if @esmerel needs to look at this as she was working on this too?

Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has too many backticks:

 `metric`_storage_resolution` 

- Merge master into PR branch
- Fix malformed metric_storage_resolution row (backticks, missing
  default column, default value, "1s/60s" -> "1/60")

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@eschabell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91757e30-d10d-4ada-a001-52c3ff9ecbbc

📥 Commits

Reviewing files that changed from the base of the PR and between 82ab6af and cc0b4e9.

📒 Files selected for processing (1)
  • pipeline/outputs/cloudwatch.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell removed the conflict Waiting on conflict to be resolved by contributor label May 29, 2026
@eschabell
Copy link
Copy Markdown
Collaborator

@devin-andrenam resolved all the conflicts.

Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devin-andrenam waiting for code PR merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants