pipeline: outputs: cloudwatch: Add StorageResolution Support#1691
pipeline: outputs: cloudwatch: Add StorageResolution Support#1691devin-andrenam wants to merge 5 commits into
Conversation
Signed-off-by: Devin Stafford <devin@andrenam.com>
dffc58f to
f5dff74
Compare
esmerel
left a comment
There was a problem hiding this comment.
Minor stylistic change. A @fluent/fluent-bit-maintainers should doublecheck the definition for technical accuracy, but I'm otherwise ok with this.
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
@devin-andrenam while waiting on the code PR changes fluent/fluent-bit#10398 you need to make, would you please fix the conflicts here so I'm ready to merge your docs update when we can? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
Conflict was due to formatting changes for style. I reverified so the submitter doesn't need to. |
|
There are on changes? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
Appears I overwrote the change fixing the conflict, I corrected it. I was afraid I'd done that at least once. |
|
@devin-andrenam there are still conflicts here that need to be addressed, not sure if @esmerel needs to look at this as she was working on this too? |
eschabell
left a comment
There was a problem hiding this comment.
This has too many backticks:
`metric`_storage_resolution`
- Merge master into PR branch - Fix malformed metric_storage_resolution row (backticks, missing default column, default value, "1s/60s" -> "1/60") Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Warning Review limit reached
More reviews will be available in 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@devin-andrenam resolved all the conflicts. |
eschabell
left a comment
There was a problem hiding this comment.
@devin-andrenam waiting for code PR merging.
Documentation update in association with according PR to fluent bit.