Prepare release 1.0.0 (Pyodide → Emscripten breaking rename)#201
Open
FeodorFitsner wants to merge 2 commits into
Open
Prepare release 1.0.0 (Pyodide → Emscripten breaking rename)#201FeodorFitsner wants to merge 2 commits into
FeodorFitsner wants to merge 2 commits into
Conversation
The sitecustomize.py injected at pip-resolution time monkey-patches `platform.system()` to the platform argument value. Renaming `Pyodide` to `Emscripten` aligns that value with what `platform.system()` actually returns in a real Pyodide runtime, so PEP 508 markers like `platform_system != 'Emscripten'` work consistently in both the build-time and in-browser micropip paths.
Bump all packages to 1.0.0 and add changelog entries marking the Pyodide → Emscripten platform argument rename as a breaking change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--platformargument valuePyodidetoEmscriptenso it matches whatplatform.system()returns inside the Pyodide runtime, keeping PEP 508 markers likeplatform_system != 'Emscripten'consistent across build-time and in-browser micropip paths.build.gradle) to 1.0.0 and refresh example apppubspec.lockfiles.CHANGELOG.mdfiles marking the rename as a breaking change.Test plan
packagecommand with--platform Emscriptenproduces the expected web buildplatform_system != 'Emscripten'resolve correctly during pip resolution🤖 Generated with Claude Code