Skip to content

Publish every module in the list, not four hard-coded ones - #23

Merged
Fiona2016 merged 1 commit into
mainfrom
fix/publish-all-modules
Aug 12, 2026
Merged

Publish every module in the list, not four hard-coded ones#23
Fiona2016 merged 1 commit into
mainfrom
fix/publish-all-modules

Conversation

@Fiona2016

Copy link
Copy Markdown
Collaborator

@flashcatcloud/axios did not reach the registry in the 0.4.0 release. The publish step named its four packages inline:

ohpm publish flashcat-core/build/default/outputs/default/flashcat_core.har …
ohpm publish flashcat-rum/…
ohpm publish flashcat-crash/…
ohpm publish flashcat-trace/…

Every other step in the job iterates HARMONY_MODULES. Adding a fifth module updated that list, so it was built and manifest-checked — and then silently skipped at the one step that mattered. The release summary and both DingTalk notifications each carried another copy of the same four names and went stale identically.

Changes

  • The publish step, the summary, and both notifications now derive the package set from HARMONY_MODULES. It moves to the workflow level so the notification jobs can read the same list the publish job used.
  • The publish loop tolerates a version the registry already holds. Catching up a package a previous run missed necessarily re-submits the ones that did go out; that should not abort the run. Any other publish failure still does.

Checked

  • Module → directory → artifact derivation matches what the build produces: flashcat_axiosflashcat-axios/build/default/outputs/default/flashcat_axios.har, confirmed by building that module locally.
  • Workflow YAML parses.

After this merges, @flashcatcloud/axios@0.4.0 is published by dispatching the workflow from publish. The other four are already submitted and awaiting registry review.

The publish step named its four packages inline while every other step iterated
HARMONY_MODULES. Adding a fifth module updated the list, the build and the
manifest checks — and silently did not publish it, because the publish step was
never reading the list. The release summary and both DingTalk notifications
carried their own copies of the same names and went stale the same way.

All four now derive from HARMONY_MODULES, which moves to the workflow level so
the notification jobs see the same list the publish job used.

The loop also tolerates a version the registry already holds. Catching up a
package a previous run missed necessarily re-submits the ones that did go out,
and that should not abort the run; any other publish failure still does.
@Fiona2016
Fiona2016 merged commit 8dcc58e into main Aug 12, 2026
6 checks passed
@Fiona2016
Fiona2016 deleted the fix/publish-all-modules branch August 12, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant