Publish every module in the list, not four hard-coded ones - #23
Merged
Conversation
The publish step named its four packages inline while every other step iterated HARMONY_MODULES. Adding a fifth module updated the list, the build and the manifest checks — and silently did not publish it, because the publish step was never reading the list. The release summary and both DingTalk notifications carried their own copies of the same names and went stale the same way. All four now derive from HARMONY_MODULES, which moves to the workflow level so the notification jobs see the same list the publish job used. The loop also tolerates a version the registry already holds. Catching up a package a previous run missed necessarily re-submits the ones that did go out, and that should not abort the run; any other publish failure still does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@flashcatcloud/axiosdid not reach the registry in the 0.4.0 release. The publish step named its four packages inline:Every other step in the job iterates
HARMONY_MODULES. Adding a fifth module updated that list, so it was built and manifest-checked — and then silently skipped at the one step that mattered. The release summary and both DingTalk notifications each carried another copy of the same four names and went stale identically.Changes
HARMONY_MODULES. It moves to the workflow level so the notification jobs can read the same list the publish job used.Checked
flashcat_axios→flashcat-axios/build/default/outputs/default/flashcat_axios.har, confirmed by building that module locally.After this merges,
@flashcatcloud/axios@0.4.0is published by dispatching the workflow frompublish. The other four are already submitted and awaiting registry review.