fix(snmp): satisfy lint checks in resilience code - #1490
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SNMP input’s resilience/health-check and filter parsing code to satisfy lint checks, primarily by removing unused helpers and addressing “replace with -1” / unchecked-return patterns.
Changes:
- Replaced
strings.Replace(..., -1)withstrings.ReplaceAllin SNMP table filter parsing. - Updated the recovery probe to defer-close the SNMP wrapper while explicitly ignoring the close error (to satisfy errcheck-style linters).
- Removed unused helper methods in SNMP table/runtime/dependency cache code.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
inputs/snmp/table.go |
Uses strings.ReplaceAll in filter parsing and removes an unused filter-dependency helper. |
inputs/snmp/runtime.go |
Removes an unused recordSuccess() wrapper (callers use the locked variant). |
inputs/snmp/health_check.go |
Wraps defer gs.Close() to explicitly ignore the returned error. |
inputs/snmp/dependency_cache.go |
Removes an unused clear() method wrapper (nil-check + lock + clearLocked). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.