Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for an optional region attribute on service credential registrations so it can be stored in Postgres and returned in peers/builder listings.
Changes:
- Extend domain + ports types to include
regionin service credentials and peer info payloads. - Persist
regioninservice_credential_registrations(schema migration + insert/select updates). - Update E2E coverage (Go DB-backed test + Hurl script) to assert
regionround-trips.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/ci/e2e-test.hurl | Registers region and asserts it appears in peers output |
| schema/004_region.sql | Adds region column to service_credential_registrations |
| ports/types_test.go | Adds JSON unmarshal test coverage for region |
| ports/types.go | Adds Region to ServiceCred and maps domain -> ports |
| ports/http_handler.go | Passes region through the register-credentials handler/service interface |
| httpserver/e2e_test.go | DB E2E asserts region persists and is returned |
| domain/types.go | Adds Region to domain.BuilderServices |
| application/service.go | Threads region through application interfaces |
| adapters/database/types.go | Maps DB credential -> domain including region |
| adapters/database/service.go | Writes/reads region to/from Postgres |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bakhtin
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Builder instances can register a
regionfield, which is returned to other builders as part of the peers info.The
regionfield can be registered as part of any service.Here's the e2e test snippet: