INTER-2195: Ship built-in ClientInterface mock using testify/mock#63
Merged
Conversation
kevinmia
commented
Jun 24, 2026
necipallef
reviewed
Jun 24, 2026
necipallef
approved these changes
Jun 24, 2026
necipallef
previously requested changes
Jun 24, 2026
necipallef
left a comment
Collaborator
There was a problem hiding this comment.
README template needs to be updated
… to README.mustache
necipallef
reviewed
Jun 25, 2026
mcnulty-fp
previously approved these changes
Jun 25, 2026
mcnulty-fp
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just one nit about the wording in the changelog.
Co-authored-by: Dan McNulty <212590662+mcnulty-fp@users.noreply.github.com>
Contributor
🚀 Following releases will be created using changesets from this PR:go-sdk@8.4.0Minor Changes
|
mcnulty-fp
approved these changes
Jun 25, 2026
Confirmed with @necipallef that this can be dismissed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
fingerprinttestpackage that gives SDK users a ready-made mock for testing their own code. The mock is built on testify/mock, a widely-used Go testing library, making it familiar and easy to read for most Go developers. The mock is backed by ClientInterface, a new interface extracted from the existing Client, which makes it injectable via the new WithClientInterface option.Changes
fingerprinttestpackage: new companion module providing a pre-built MockClient for testing code that depends on the Fingerprint SDKREADME.mdforfingerprinttestand added a usage guideCHANGELOG.mdforfingerprinttestREADME.mustacheby adding Testing section that referencesfingerprinttestgo.work: addedfingerprinttestto the workspaceValidation
fingerprinttestREADME for an example of a test