test: add Angular version test matrix (toolchain swap-in-place)#108
Closed
JuroUhlar wants to merge 1 commit into
Closed
test: add Angular version test matrix (toolchain swap-in-place)#108JuroUhlar wants to merge 1 commit into
JuroUhlar wants to merge 1 commit into
Conversation
Replace the per-version workspace scaffolding approach with a declarative CI matrix that keeps the committed workspace and only swaps the installed Angular toolchain (core/common/cli/compiler-cli/ng-packagr) plus the version-matched TypeScript, zone.js and jest-preset-angular. Each matrix entry builds the library and runs the existing jest suite. Also add .node-version and an engines field for local Node consistency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fpy8yBUra4yxpMp5F9Xm7a
Contributor
pnpm exec changesetto create a changeset. |
Contributor
Coverage report
Test suite run success10 tests passing in 2 suites. Report generated by 🧪jest coverage report action from ef10927 Show full coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a CI workflow that verifies the library builds and its unit tests pass against every supported Angular major (15–21).
This is a simpler alternative to the scaffolding approach in #85. Instead of generating a fresh Angular workspace per version, it keeps the committed workspace (
angular.json,tsconfig*, jest config) and just swaps the installed Angular toolchain, then runs the existingng build+jest.How
A single matrix job. The only per-version knowledge is the compatibility table in
matrix.include(Node / TypeScript / zone.js / jest-preset-angular), which is intrinsic to Angular's own support policy:pnpm addthe version-matched@angular/*,ng-packagr,typescript,zone.js,jest-preset-angular.ng build fingerprintjs-pro-angular(catches ng-packagr / compiler-cli breakage).pnpm test(the existing jest suite; catches runtime/API breakage).Footprint
3 files:
.github/workflows/test-matrix.yml,.node-version, and anenginesfield inpackage.json.Scope / known trade-off
This covers library build + unit tests across 15–21. It does not exercise each version's freshly generated project scaffolding, nor does it compile a real consumer app against the published package. A follow-up can add a consumer-build job (build the SDK to
dist, then compile committed per-version demo apps against it) to close that gap — kept out of this PR to keep the first step minimal.🤖 Generated with Claude Code
https://claude.ai/code/session_01Fpy8yBUra4yxpMp5F9Xm7a
Generated by Claude Code