Skip to content

Fix async interrupt breaking bookkeeping in a Summary #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iand675 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix async interrupt breaking bookkeeping in a Summary #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e04e80f
fix async interrupt breaking bookkeeping in an observer
iand675 Jul 27, 2022
a796814
Merge branch 'fimad:master' into master
phubars-mercury Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prometheus-client/src/Prometheus/Metric/Summary.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ summary info quantiles_ = Metric $ do

instance Observer Summary where
-- | Adds a new observation to a summary metric.
observe s v = doIO $ withMVar (reqSketch s) (`ReqSketch.insert` v)
observe s v = doIO $ withMVarMasked (reqSketch s) (\rs -> rs `ReqSketch.insert` v)

@jml jml Jul 28, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What's the motivation for adding the \rs -> rs bit?

No particular objections, just curious.

@jml jml Jul 28, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add a comment explaining why we are masking here. Something along the lines of your PR description would be great.

@fimad fimad Sep 18, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on adding a comment directly to the code.


-- | Retrieves a list of tuples containing a quantile and its associated value.
getSummary :: MonadIO m => Summary -> m [(Rational, Double)]
Expand Down