Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Enhance
WrapNotificationin the webview preload to implement full standardEventTargetbehavior and forward notification click events to guest services and Service Workers:WrapNotificationnow extendsEventTarget, enabling bothaddEventListener("click", ...)andonclickcallbacks with a standardEventargument.title,body,data,tag,icon,dir,lang,silent) on the notification instance.ServiceWorkerRegistration.prototype.showNotificationto returnPromise.resolve()(matching W3C spec) and forward completeoptions(includingdataandtag).NOTIFICATION_CLICKpostMessage tonavigator.serviceWorker.controllerand WhatsAppNOTIFICATION_BANNER_CLICKEDbus event when clicked.test/webview/notifications.test.ts.Motivation and Context
Fixes #263. When users clicked desktop notification banners for services like WhatsApp, Slack, Discord, or Google Chat, Ferdium would focus and switch to the active service tab, but the guest webview never opened the relevant conversation/channel context because
WrapNotificationdid not supportaddEventListener("click"), omitted notification metadata properties, and did not notify Service Workers.Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Fix issue where clicking desktop notifications did not open the relevant conversation or channel in guest services.
Relates to #2590 and ferdium/ferdium-recipes#760.