Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Description of Change
Adds an optional WebRTC IP handling policy to each service. Services inherit the global policy by default, but users can override it from the service settings. The selected policy is applied to the service webview and pop-up windows, and updates immediately when the service is saved.
Motivation and Context
Some calling services, including Google Voice, require WebRTC IP exposure for call audio to connect. The existing global-only setting forces users to expose addresses to every service or lose calling functionality.
Closes #1398.
Related: #1575.
Checklist
pnpm prepare-code)pnpm testpassesA targeted lint check passed for
src/models/Service.ts. The full build and test suite were not run.Release Notes
Add per-service WebRTC IP handling policy overrides for calling services.