Repository navigation
Conversation
ponces
force-pushed
the
fix/outlook-single-window
branch
from
September 18, 2026 14:15
c49be0c to
358c2e8
Compare
ponces
force-pushed
the
fix/outlook-single-window
branch
from
September 18, 2026 14:17
358c2e8 to
c629fed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Outlook opens an intermediate about:blank popup and navigates it through its WindowProxy, which bypasses the existing navigation handling. This change associates those blank popups with their child windows and listens for navigation events directly on the child. Non-blank destinations are prevented from loading inside Ferdium, opened using openExternalUrl, and the temporary popup is closed afterward.
Testing
pnpm typecheckpnpm exec eslint src/index.ts --max-warnings 0