Repository navigation
fix: dispatch notification click events - #2558
Open
sedatyildiznet wants to merge 1 commit into
Open
sedatyildiznet wants to merge 1 commit into
sedatyildiznet wants to merge 1 commit into
Conversation
Member
|
Hello! Thank you for rasing this PR. Can you please follow the PR template, add a description and also check each step on the Checklist? Thank you very much! |
Author
|
Hello! Thank you for the feedback. I’ve updated the PR description according to the template and completed the checklist. Please let me know if anything else is needed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Description of Change
This change makes Ferdium's wrapped Web Notification behave like an EventTarget when a desktop notification is clicked.
clickeventonclickandaddEventListener('click', ...)thisvalue and event targetdata, available to click handlersMotivation and Context
The current wrapper calls
onclickwithout an event or the correct handler context. It also copies the native Notification prototype without initializing EventTarget state. As a result, services usingaddEventListeneror readingevent.target.datacannot reliably navigate to the message or channel that produced the notification.This improves notification context navigation and is related to #263.
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Improve navigation from desktop notifications by dispatching standards-compatible click events.