feat: add language server implementation#249
Conversation
🦋 Changeset detectedLatest commit: 6625cbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Package size report
|
illright
left a comment
There was a problem hiding this comment.
wow, I am amazed at how little changes were required, great job! One comment about the API
There was a problem hiding this comment.
issue: this looks kinda weird, to be honest. I get that it is to prevent breaking changes, but we are not 1.0.0 yet, so I wouldn't worry too much about it in favor of a well-designed API for 1.0.0
suggestion: let's define start as a separate field? Or alternatively, to avoid breaking changes, make line?: number | { start: number; end: number }, and the same for column?
No description provided.