Skip to content

feat: add language server implementation#249

Open
Solant wants to merge 11 commits into
masterfrom
feat/language-server
Open

feat: add language server implementation#249
Solant wants to merge 11 commits into
masterfrom
feat/language-server

Conversation

@Solant

@Solant Solant commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6625cbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@feature-sliced/steiger-plugin Minor
@steiger/types Minor
@steiger/pretty-reporter Minor
steiger Minor
@steiger/integration-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Solant
Solant marked this pull request as draft July 16, 2026 22:29
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

📊 Package size report

PackageBeforeAfter
steiger-plugin-fsd1638.92 KBNo change
steiger67.57 KBNo change
toolkit10.07 KBNo change

@illright illright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, I am amazed at how little changes were required, great job! One comment about the API

Comment thread packages/types/index.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: this looks kinda weird, to be honest. I get that it is to prevent breaking changes, but we are not 1.0.0 yet, so I wouldn't worry too much about it in favor of a well-designed API for 1.0.0

suggestion: let's define start as a separate field? Or alternatively, to avoid breaking changes, make line?: number | { start: number; end: number }, and the same for column?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Solant
Solant marked this pull request as ready for review July 25, 2026 21:34
@Solant
Solant requested review from Gaic4o and illright July 25, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants