feat: support custom Inno Setup installation path via INNO_SETUP_PATH env var#341
Merged
Conversation
… env var Allow users to specify a custom Inno Setup 6 installation path via the INNO_SETUP_PATH environment variable. If not set, falls back to the default path (C:\Program Files (x86)\Inno Setup 6), then to 'iscc' in system PATH (compatible with Scoop and other package managers). Closes #244 Closes #318 Closes #334
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
fastforge-website | 1362dbf | Jun 19 2026, 03:31 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
fastforge-studio | 1362dbf | Jun 19 2026, 03:32 PM |
Expose and use extra environment variables for Inno Setup and filter locales by available language files. - Export InnoSetupCompiler from package entrypoint. - Add InnoSetupCompiler._extraEnv, setExtraEnv(), and public resolveIsccPath() so callers (e.g. distributor) can inject env vars that take priority over Platform.environment when resolving ISCC.exe. - Refactor _resolveIsccPath to use the injected env and unify resolution logic. - In InnoSetupScript, add a map of locale -> .isl file names and implement _getAvailableLocales() to only include locales whose .isl files exist in the detected Inno Setup installation (or keep all locales when falling back to PATH). Use this filtered list for the template variable LOCALES. - In UnifiedDistributor, pass provided variables (such as INNO_SETUP_PATH) to InnoSetupCompiler.setExtraEnv so distribution config can influence Inno Setup resolution. These changes allow configuration-driven Inno Setup path resolution and avoid generating installers with locales for which language files are not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for specifying a custom Inno Setup 6 installation path via the
INNO_SETUP_PATHenvironment variable, resolving the hardcoded path issue.Changes
inno_setup_compiler.dart— TheISCC.exelookup now follows this priority order:INNO_SETUP_PATHenvironment variable (if set and the directory containsISCC.exe)C:\Program Files (x86)\Inno Setup 6iscccommand found in systemPATH(compatible with Scoop and other package managers)Docs — Both English (
docs/en/makers/exe.md) and Chinese (docs/zh/makers/exe.md) documentation updated with usage examples for PowerShell and CMD.Usage
When
INNO_SETUP_PATHis not set, behavior is unchanged — it uses the default path first, then falls back toPATH.Related Issues
Closes #244 — 能定义 Inno Setup 6 的安装位置吗？目前只能固定在 C 盘？
Closes #318 — flutter_app_packager 调用 inno setup 时使用了硬编码的地址，能否支持更灵活的
Closes #334 — innoset 自定义安装路径