Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android Hermes reports the requested h11/h24 cycle but formats the midnight hour using h12/h23, and its hour12 choice can disagree with the locale preferred cycle. Use Android ICU to select the locale preferred 12- or 24-hour cycle, preserve the exact resolved hour symbol in the final pattern, and omit day-period fields for 24-hour styled skeletons. The pre-API-24 java.text backend retains its existing selection behavior.
This is the Android counterpart to #2208 and addresses #2209. Standalone React Native / Chromium WebView reproduction: https://github.com/mozzius/hermes-datetimeformat-repro
Test plan
The focused regression passes on API 35. The entire HermesIntlAndroidTest class currently has unrelated failures in this checkout: three unavailable asset files and two expected regular spaces where Android 15 ICU emits a narrow no-break space.