perf: don't gate indexing on compliation completing#769
Open
scohen wants to merge 1 commit into
Open
Conversation
When reindex was run at the same time as compilation, it caused something in the BEAM vm to soak up CPU. This was a permanent condition that would affect the project node until it was restarted. Since we swapped out the ETS based index backend for a SQLite one, we should be able to reindex and compile at the same time. This will dramatically reduce the amount of time the project node takes to boot. This change makes it so indexing and compilation occur at the same time, and we fix up the index after compilation completes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reindex was run at the same time as compilation, it caused something in the BEAM vm to soak up CPU. This was a permanent condition that would affect the project node until it was restarted.
Since we swapped out the ETS based index backend for a SQLite one, we should be able to reindex and compile at the same time. This will dramatically reduce the amount of time the project node takes to boot.
This change makes it so indexing and compilation occur at the same time, and we fix up the index after compilation completes