Skip to content

chore(kms): add delete-at field #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luxium30 wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −2
Open

chore(kms): add delete-at field #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34b6d84
fix(kms): add delete-at field
luxium30 Jul 8, 2026
e47e632
always show delete-at field
luxium30 Jul 15, 2026
8fa1671
fix go.sum
luxium30 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/kms/key/key_show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ type KeyShowOutput struct {
Rotation string `json:"rotation" validate:"required"`
Usage string `json:"usage" validate:"required"`
Source v3.GetKmsKeyResponseSource `json:"source" validate:"required"`
Description string `json:"description" validate:"required"`
Description string `json:"description,omitempty"`
DeleteAt time.Time `json:"delete-at,omitempty"`
}

func (o *KeyShowOutput) Type() string { return "KMS key" }
Expand Down Expand Up @@ -77,10 +78,12 @@ func (c *KeyShowCmd) CmdRun(_ *cobra.Command, _ []string) error {
ReplicasStatus: formatReplicaStatus(resp.ReplicasStatus),
Material: formatKeyMaterial(resp.Material),
Rotation: formatKeyRotationConfig(resp.Rotation),
Usage: string(resp.Usage),
Usage: resp.Usage,
Source: resp.Source,
Description: resp.Description,
DeleteAt: resp.DeleteAT,
}

return c.OutputFunc(&out, nil)
}

Expand Down
7 changes: 7 additions & 0 deletions pkg/output/outputter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"reflect"
"strings"
"text/template"
"time"

"github.com/exoscale/cli/table"
v3 "github.com/exoscale/egoscale/v3"
Expand Down Expand Up @@ -209,6 +210,12 @@ func Table(o interface{}) {
label = l
}

// If the field is a zero-value time.Time, print "n/a".
if ts, ok := v.Field(i).Interface().(time.Time); ok && ts.IsZero() {
tab.Append([]string{label, "n/a"})
continue
}

switch v.Field(i).Kind() {
case reflect.Slice:
// If the field value is a slice and is empty, print "n/a" instead of 0.
Expand Down
Loading