Skip to content

Fix saved view deletion#2314

Merged
ejsmith merged 2 commits into
mainfrom
codex/fix-saved-view-delete
Jun 19, 2026
Merged

Fix saved view deletion#2314
ejsmith merged 2 commits into
mainfrom
codex/fix-saved-view-delete

Conversation

@ejsmith

@ejsmith ejsmith commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Clear saved-view query params through a helper that respects the current route's supported params.
  • Avoid assigning unsupported filters, saved, or sort keys while clearing the active saved view.
  • Add unit coverage for both full saved-view query state and route-limited query state.

Why

Deleting an active saved view first clears the selected view state. Stack/event routes do not define every optional saved-view query key in kit-query-params, so assigning unsupported keys caused the clear path to throw before the delete flow could finish, leaving the confirmation dialog open.

Validation

  • npm run test:unit -- src/lib/features/saved-views/use-saved-views.test.ts --run
  • Local Aspire browser repro: created and deleted a disposable saved stack view; the confirmation dialog closed, navigation returned to /next/stack, and the API returned 404 for the deleted saved view.

Breaking changes

None.

@ejsmith ejsmith marked this pull request as ready for review June 19, 2026 00:19
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 39% 40% 134
Exceptionless.Core 70% 63% 7967
Exceptionless.Insulation 24% 23% 203
Exceptionless.Web 72% 61% 4135
Summary 69% (14202 / 20562) 61% (7360 / 11982) 12439

@ejsmith

ejsmith commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/preview

@github-actions github-actions Bot added the dev-preview Deploy this pull request to the shared dev environment. label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Preview deployed

@ejsmith ejsmith merged commit 7a88da9 into main Jun 19, 2026
12 checks passed
@ejsmith ejsmith deleted the codex/fix-saved-view-delete branch June 19, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-preview Deploy this pull request to the shared dev environment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant