revert: support new bee OTLP tracing flags (#585)#594
Closed
martinconic wants to merge 1 commit into
Closed
Conversation
This reverts commit 34f33e4. PR #585 introduced `tracing-otlp-endpoint`, `tracing-otlp-insecure`, and `tracing-sampling-ratio` config keys in the bee config template, replacing `tracing-endpoint`. Bee master does not yet recognise these keys (the OpenTelemetry migration is on the `feat/opentelemetry-migration` branch and hasn't merged), so bee fails startup with "unknown parameters" and bee PR CI consistently times out at "bootnode-0 is not ready yet". Revert until the bee OpenTelemetry migration lands; #585 will be reopened so the change can re-land alongside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #585.
Why
PR #585 introduced
tracing-otlp-endpoint,tracing-otlp-insecure, andtracing-sampling-ratioconfig keys in the rendered bee config (replacingtracing-endpoint). Bee master does not yet recognise those keys — the OpenTelemetry migration is on thefeat/opentelemetry-migrationbranch and hasn't merged.The mismatch causes every bee PR's Beekeeper / Integration tests job to fail: bee exits at startup with
(verified via the
kubectl_logsdebug artifact from a failed run). Bee never becomes ready, the readiness probe times out, the cluster setup hits the 30-minute limit.What this does
Plain
git revertof 34f33e4 — restorestracing-endpointin the BeeConfig struct, orchestration Config, k8s template, and the three cluster yamls.Follow-up
Reopen #585 so it can re-land alongside the bee OpenTelemetry migration.