Repository navigation
Conversation
Contributor
|
gnidan
added a commit
that referenced
this pull request
Oct 7, 2026
* bugc: compile `!` as a logical not * bugc: link the changelog entry to #353 * bugc: end each source range at its last token * bugc: link the changelog entry to #362 * bugc: add block.prevrandao * bugc: link the changelog entries to #363 * bugc: hash several value-type words with keccak256 * bugc: link the changelog entries to #365 * bugc: slice a fixed-size bytes value by its bytes * bugc: link the changelog entry to #357 * bugc: hash the data of dynamic bytes and strings * bugc: link the changelog entry to #360 * bugc: give a caller's call JUMP the invoke's arguments * bugc: list variables before a function's first statement * bugc: store a memory string's bytes when assigning it to storage A storage write took its value as a word, so a memory string or bytes reference wrote its memory address into the slot. Code generation now encodes the referenced bytes as Solidity does: inline with length * 2 up to 31 bytes, else length * 2 + 1 in the slot and the data from keccak256(slot), with the last word's trailing bytes cleared. A slice now carries the bytes type, so its value is recognized too. * bugc: link the changelog entry to #355 * bugc: say why the bytes test slices without naming the copy width * bugc: copy all of a slice's bytes irgen built a slice's data as a read and a write, and a read or write moves at most one word, so only the first 32 bytes were copied. Add a copy IR instruction (CALLDATACOPY from calldata, MCOPY from memory) and emit it for the slice's data. * bugc: link the changelog entries to #359 * bugc: copy a struct read from storage into memory * bugc: link the changelog entries to #361 * bugc: lay storage arrays out as Solidity does * bugc: add push to dynamic arrays in storage
Member
Author
|
Included in #368. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG had no way to hash more than one value:
keccak256took exactly onebytesorstringargument, and BUG has noabi.encodeor concatenation. A roll like Solidity'skeccak256(abi.encode(block.prevrandao, msg.sender))could not be written.keccak256now has two forms, told apart by the argument types:bytesorstringhashes its data, as before.address,bool,bytesN) hashes their 32-byte words, concatenated in order. For integers,addressandboolthis is Solidity'skeccak256(abi.encode(a, b, ...)), including a negative signed value's sign-extended word.A
bytesorstringamong several arguments is a type error. A single value-type argument (keccak256(n)) now type-checks too; it hashes its word, which is what abytesNargument already did.A
bytesNnarrower than 32 bytes hashes its full word with its bytes at the right end, as BUG holds it.abi.encodeputs them at the left end, so those hashes differ from Solidity's;x as bytes32moves the bytes to the left end and matches. The examples README documents both forms and this difference.In the IR,
hashnow hasvalues: Value[]in place ofvalue(and the unusedvalueDebug), and each pass that reads operands handles the list. Code generation stores one or two words in the scratch space at0x00, as before, and more words at the free memory pointer, without allocating them. Constant folding hashes constant words the same way, so a hash of constants folds at levels 1 to 3.@ethdebug/bugc-react's IR and CFG views show every operand.The behavioral tests compare against
keccak256over the words ofabi.encodeat levels 0 to 3: constants, locals, storage values,msg.sender, narrow integers, abool, a negativeint8, abytes32with three words in all, abytes4before and after a cast tobytes32, and a roll. One test checks that the optimizer foldskeccak256(7, 9)to the same constant. I also checked one program against solc 0.8.37: itskeccak256(abi.encode(...))results for(int8(-3), a),(uint8(200), true)and(42, msg.sender)equal bugc's at each level.