Repository navigation
web: show storage as of the current step in the trace viewer - #319
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trace viewer read storage once, after the whole transaction had run, and used that one snapshot at every step. Any storage variable therefore showed its final value from step 0 on, and the Storage section never changed while stepping.
Trace steps carry no storage, so this reads each SSTORE from its operands on the stack and builds the storage for every step from the storage before execution plus the SSTOREs that ran before that step. That matches the stack and memory in a step, which are also the state before the step's own instruction runs. The viewer uses the per-step storage for the Storage section, variable values and call arguments.
The logic is a small function in
storageByStep.tswith a test next to it. This is the first test inpackages/web.