Build failing on latest nightly: SIGKILL not found in libc (unix::process)

[FelixLttks]

Bug description

Building std on the latest nightly fails for the espidf target (e.g., riscv32imac-esp-espidf) with the following error:

error[E0425]: cannot find value `SIGKILL` in crate `libc`
   --> /.../rustlib/src/rust/library/std/src/os/unix/process.rs:498:53
    |
498 |         self.handle.send_process_group_signal(libc::SIGKILL)
    |

Environment

• Target: riscv32imac-esp-espidf
• Container/Toolchain: Occurs when using the espressif/idf-rust:esp32c6_latest Docker image, which pulls the latest nightly.

Cause

This is an upstream regression caused by rust-lang/rust commit 7bf5fe7bf84f5b94e5970de18543abac0579209c.
rust-lang/rust@7bf5fe7

The commit added the unix_kill_process_group feature to std::os::unix::process. Because espidf is categorized under the unix family, it attempts to compile this code, but the espidf libc does not define SIGKILL.

[ivmarkov]

Thanks - the analysis is correct.

However the issue cannot be fixed in this crate and we need an upstream PR addressing it.
Also whether ESP-IDF should be part of the unix family has been debated to death and has no clear answer :-)

An upstream fix would roughly be:

#[cfg(not(target_os = "espidf"))]
fn kill_process_group(&mut self) -> io::Result<()> {
    self.handle.send_process_group_signal(libc::SIGKILL)
}

#[cfg(target_os = "espidf")]
fn kill_process_group(&mut self) -> io::Result<()> {
    crate::sys::pal::unsupported::unsupported()
}

If you feel like it, you might submit such a fix upstream. Otherwise I'll do, in the next days, when I get to it.

[ivmarkov]

Fix merged upstream - thanks @FelixLttks !