Conversation
bjoernQ
reviewed
Sep 14, 2026
| //! let mut written = 0; | ||
| //! let audio_sample_len = audio_sample.iter().len(); | ||
| //! while written < audio_sample_len { | ||
| //! let out_written = transfer.push_with(|out| { |
Contributor
There was a problem hiding this comment.
to have this usage example aligned with the RX example (and show more of the API surface) it would be better to check available_bytes like the RX example does
DivineGod
force-pushed
the
i2s-write-doc
branch
2 times, most recently
from
September 15, 2026 00:01
576ce4a to
75350d2
Compare
bjoernQ
approved these changes
Sep 17, 2026
This is in response to having issues upgrading from 1.1.0 to 1.2.0 [esp-rs#6275](esp-rs#6275)
DivineGod
force-pushed
the
i2s-write-doc
branch
from
September 17, 2026 08:03
75350d2 to
ed17697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmtcommand to ensure that all changed code is formatted correctly.skip-changelogormanual-changeloglabel as appropriate.Extra:
Pull Request Details 📖
Description
This is in response to having issues upgrading from 1.1.0 to 1.2.0 #6275 I have added a section to the I2S module level documentation about writing to the I2S DMA Buffer.
Testing
I tested the changes to the documentation by creating a reproduction repository.
There's a branch for esp-hal 1.1.0, esp-hal 1.2.0, and for async esp-hal 1.2.0. All tested on an esp32c6 device.
Changelog
esp-hal