Change interrupt type from Eof to Done in wait_for_available_async - #6247
Dominaezzz wants to merge 2 commits into
Conversation
This is the more correct interrupt for availability
|
/hil full --tests i2s Any reason this is draft? |
|
Triggered full HIL run for #6247. Run: https://github.com/esp-rs/esp-hal/actions/runs/33745767742 Status update: ❌ HIL (full) run failed (conclusion: failure). |
|
@Dominaezzz we'll be issuing a patch release in the next week or so, would you mind fixing up this PR ready for it? |
(I missed this comment yesterday for some reason). I put it in draft because I thought I'd need a migration guide and I parked this until I'd have time to write one. But we've clarified that in a different PR.
The hil test failure in Thanks for the poke! But I won't be able to make it in time for the patch release 🥲. |
This is the more correct interrupt for availability
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.skip-changelogormanual-changeloglabel as appropriate.Extra:
Pull Request Details 📖
Description
A small tweak on top of #5603. Not a breaking change.
Testing
HIL and docs
Changelog
esp-hal