Skip to content

Change interrupt type from Eof to Done in wait_for_available_async - #6247

Draft
Dominaezzz wants to merge 2 commits into
mainfrom
Dominaezzz-patch-1
Draft

Dominaezzz wants to merge 2 commits into
mainfrom
Dominaezzz-patch-1

Conversation

@Dominaezzz

@Dominaezzz Dominaezzz commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

This is the more correct interrupt for availability

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • I have added changelog entries and/or migration guide notes in the sections below, or I will ask a maintainer to add the skip-changelog or manual-changelog label as appropriate.
  • My changes are in accordance to the esp-rs developer guidelines

Extra:

Pull Request Details 📖

Description

A small tweak on top of #5603. Not a breaking change.

Testing

HIL and docs


Changelog

esp-hal

  • No changelog necessary.

This is the more correct interrupt for availability
@Dominaezzz
Dominaezzz marked this pull request as ready for review August 31, 2026 18:59
@Dominaezzz Dominaezzz mentioned this pull request Sep 1, 2026
@Dominaezzz
Dominaezzz marked this pull request as draft September 1, 2026 14:25
@MabezDev MabezDev added the esp-hal-backport Backport this PR to the latest esp-hal-x.y.x branch.” label Sep 1, 2026
@MabezDev

MabezDev commented Sep 3, 2026

Copy link
Copy Markdown
Member

/hil full --tests i2s

Any reason this is draft?

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Triggered full HIL run for #6247.

Run: https://github.com/esp-rs/esp-hal/actions/runs/33745767742

Status update: ❌ HIL (full) run failed (conclusion: failure).

@MabezDev

MabezDev commented Sep 4, 2026

Copy link
Copy Markdown
Member

@Dominaezzz we'll be issuing a patch release in the next week or so, would you mind fixing up this PR ready for it?

@Dominaezzz

Copy link
Copy Markdown
Collaborator Author

Any reason this is draft?

(I missed this comment yesterday for some reason).

I put it in draft because I thought I'd need a migration guide and I parked this until I'd have time to write one. But we've clarified that in a different PR.

@Dominaezzz we'll be issuing a patch release in the next week or so, would you mind fixing up this PR ready for it?

The hil test failure in dma_does_not_lock_up_on_core_1 looks non trivial and I won't have time to dig into it in the next two weeks unfortunately.

Thanks for the poke! But I won't be able to make it in time for the patch release 🥲.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esp-hal-backport Backport this PR to the latest esp-hal-x.y.x branch.”

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants