Add KyroDB ANN-Benchmarks integration#622
Open
vatskishan03 wants to merge 1 commit into
Open
Conversation
Add the KyroDB ANN-Benchmarks algorithm package and register it in the benchmark workflow matrix. This submission pins the validated KyroDB engine revision in the algorithm Dockerfile and includes the Euclidean/cosine adapter, official benchmark parameter groups, and CI coverage through the upstream ANN-Benchmarks workflow. Validated locally against the upstream workflow path: - pytest - python install.py --algorithm kyrodb - python run.py random-xs-20-angular (single-query) - python run.py random-xs-20-angular --batch - plot.py, data_export.py, create_website.py
There was a problem hiding this comment.
Pull request overview
Adds KyroDB as a new ANN-Benchmarks algorithm integration, including the Python adapter, Docker image build, and CI workflow registration so it can be built and benchmarked alongside existing libraries.
Changes:
- Introduces a
KyroDBPython adapter that calls intolibkyrodb_engineviactypes. - Adds KyroDB algorithm configuration (
config.yml) and a Dockerfile to build/copy the KyroDB FFI library into the benchmark image. - Registers
kyrodbin the GitHub Actions benchmark workflow matrix.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ann_benchmarks/algorithms/kyrodb/module.py |
Implements the KyroDB ANN adapter + FFI loader and query/build plumbing. |
ann_benchmarks/algorithms/kyrodb/config.yml |
Defines KyroDB run groups/params for benchmark runs. |
ann_benchmarks/algorithms/kyrodb/Dockerfile |
Builds KyroDB engine with FFI support and installs the shared library into the runtime image. |
.github/workflows/benchmarks.yml |
Adds kyrodb to the benchmark CI matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| raise ValueError( | ||
| f"query dimension mismatch: expected {self._dimension}, got {vec.size}" | ||
| ) | ||
| if self._normalize and not self._trusted_input: |
Comment on lines
+14
to
+32
| trusted_input: true | ||
| query_args: [[20, 40, 80, 120, 200, 300, 400, 600]] | ||
| M-24: | ||
| args: | ||
| M: 24 | ||
| ef_construction: 200 | ||
| trusted_input: true | ||
| query_args: [[20, 40, 80, 120, 200, 300, 400, 600]] | ||
| M-36: | ||
| args: | ||
| M: 36 | ||
| ef_construction: 300 | ||
| trusted_input: true | ||
| query_args: [[20, 40, 80, 120, 200, 300, 400, 600]] | ||
| M-48: | ||
| args: | ||
| M: 48 | ||
| ef_construction: 300 | ||
| trusted_input: true |
Comment on lines
+9
to
+15
| try: | ||
| from ..base.module import BaseANN | ||
| except ImportError: | ||
| class BaseANN: | ||
| pass | ||
|
|
||
|
|
vatskishan03
commented
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kyrodbin the benchmark workflow matrixValidation
python install.py --algorithm kyrodbpython run.py --docker-tag ann-benchmarks-kyrodb --max-n-algorithms 3 --runs 2 --dataset random-xs-20-angular --run-disabled --timeout 300python run.py --docker-tag ann-benchmarks-kyrodb --max-n-algorithms 3 --runs 2 --dataset random-xs-20-angular --run-disabled --batch --timeout 300python plot.py --dataset random-xs-20-angular --output plot.pngpython plot.py --dataset random-xs-20-angular --output plot-batch.png --batchpython data_export.py --out test.csvpython create_website.py --outputdir . --scatter --latexNotes
angular/cosineandeuclidean/l2.inner_productis intentionally unsupported in this adapter.7f113a73c6d6853a2c111e78dc87ed53acc95bee.