Preserve snapshot chunk retry budget - #2437
Open
a-shannon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxDeliveryChecksbudget to terminate repeated chunk retries.Root cause
checkDeliveryincremented the stored attempt count, butrequestUtxoSetChunkrecreated theDeliveryTrackerentry without passing that count. The default value of zero replaced the previous state on every retry, so the configured maximum could never be reached for snapshot chunks.Impact
When UTXO snapshot bootstrap is enabled, an unavailable or non-delivering chunk could be requested repeatedly instead of exhausting the configured retry budget. This could prolong or stall that bootstrap mode while producing repeated peer penalties, timers, logs, and network traffic.
This change does not affect consensus rules, transaction validity, serialization, or default configuration.
Scope
The change enforces the existing retry budget. It does not alter snapshot-plan recovery after the budget is exhausted.
This is independent of #2434, which corrects the request type used for snapshot manifest retries. The source changes are adjacent, so this branch may need a small rebase if #2434 merges first.
Validation
99, observed0.sbt "testOnly org.ergoplatform.network.ErgoNodeViewSynchronizerSpecification"(26 tests)sbt "testOnly scorex.core.network.DeliveryTrackerSpec org.ergoplatform.nodeView.history.UtxoSetSnapshotProcessorSpecification org.ergoplatform.network.RequestModifiersSpecification"(4 tests)