Fix decentralized clients connection issue#1110
Open
ahzero7d1 wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue: #1109
This pull request tackles decentralized learning peer connection stability and synchronization issues. We are mainly solving 3 main issues.
Connection Ready Check and Signaling Weight Sharing
ConnectionsRetry,StartWeightSharingmessages are newly added to prevent faster peers proceed to weight sharing while slower peers are still establishing connections. Detailed process is as follows:ConnectionsReadymessage to the server.ConnectionsReadymessages.ConnectionsReadymessages matches the number of expected participants for the round, the server sends aStartWeightSharingmessage to all round participants.StartWeightSharing.Connection Retries and Failed Client Disconnection
RetryPeerConnections,ConnectionFailmessages are newly added. In addition, webapp shows error message when a client is disconnected after repetitive failure.maxConnectionRetryparameter is added totrainingInformation, and added to the webapp so that users can specify the value during task creation.Connection failure handling process is as follows:
maxConnectionRetry, the server sends aRetryPeerConnectionmessage to all peers in the current round.RetryPeerConnection, they clean up their peer pool and aggregator nodes, then rerun the peer connection phase.maxConnectionRetryattempts, the server removes the failed peers from the round peer list.ConnectionFailmessage to the failed peers.ConnectionFail, it disconnects from the server.RetryPeerConnectionand retry the peer connection phase without the failed peers.Model Syncing for Participants Joining in the Middle of Training
Model syncing between peers is implemented for participants who are joining in the middle of training.
ModelSyncRequest,SignalModelProvider,SignalNewPeer,SharedModelmessages are newly added. In addition,ModelWeightAccessinterface was added indisco.tsso that client object can adjust model weights when it receives the latest model from the provider peer.Model syncing process is as follows:
NewDecentralizedNodeInfo.NewDecentralizedNodeInfo, the new client sets a local flag indicating that it needs model syncing.ModelSyncRequestmessage to the server.ModelSyncRequest, the server sends messages as step 5 and 6, using selected model provider information from previous training round.SignalModelProviderto the new participant with information about the provider peer.SignalNewPeerto the provider peer with information about the newly joined peer.SharedModelmessage.