fix(validator): fall through OSS scoring when mirror omits base_ref#1637
Open
RealDiligent wants to merge 1 commit into
Open
fix(validator): fall through OSS scoring when mirror omits base_ref#1637RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
Skip the base-ref eligibility gate when mirror rows omit base_ref, matching issue-discovery fall-through for pre-backfill data. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Summary
Pre-backfill mirror rows can omit
base_ref. OSS scoring treatednullas''and rejected those merged PRs at load time, while issue discovery already fall-throughs missing branch metadata.Skip the base-ref gate when
base_ref is None, matching the existing nullhead_ref/head_repo_full_namebehavior and issue-discovery parity.Root cause
check_merged_branch_eligibilityusedbase_ref or '', so a missingbase_refbecame an empty string that never matched the acceptable branch set. Valid merged PRs were dropped before scoring.Fix approach
Gate on
base_refonly when it is present (base_ref is not None), consistent with issue discovery (scan.py) and existing nullhead_reffall-through.Impact
Pre-backfill mirror rows and any merged PR missing branch metadata can score OSS contributions instead of being silently dropped.
Risk / tradeoffs
base_refvalues are still rejected.Test plan
test_null_base_ref_skips_checkintests/validator/oss_contributions/mirror/test_scoring.py