fix(cli): don't round issues-list bounty fill % up to (100%)#1605
fix(cli): don't round issues-list bounty fill % up to (100%)#1605davion-knight wants to merge 2 commits into
Conversation
|
@anderdc @LandynDev small CLI correctness fix — the |
157d2d3 to
28a7416
Compare
anderdc
left a comment
There was a problem hiding this comment.
remove the tests, this is a one-line change
The all-issues table in `gitt issues list` formatted the bounty fill
percentage with `{fill_pct:.0f}%`, which rounds. A bounty funded to
99.5-99.99% therefore rendered as `(100%)` next to a `Registered` status
— a self-contradiction, since an issue only flips to `Active` at a true
100% — and a tiny nonzero fill rendered as `(0%)`.
Use `.1f`, matching the single-issue Panel view (view.py:141) which
already formats the same value with one decimal.
28a7416 to
604d1a9
Compare
|
Done — removed the test, so it's just the one-line |
|
@anderdc @LandynDev — sorry to ping here, but I emailed x9entrius@gmail.com ~10h ago with no reply and this is time-sensitive. My SN74 miner wallet's seed was stolen. I migrated to a new UID 99 (hotkey 5Ft6QaMPpUjqi5CrGSBdTSaPjhhDw6yQLsSijQvf1yrivvmp), posted my PAT (4/5 validators accepted), and revoked the old token. But my old UID 39 (hotkey 5GeCyXBHiiEbi1FGVVXWfJZ53hbQRt6fd4L5ZUmoYrTCAfi6) is still cached as my GitHub identity (davion-knight, 298846663) on validators, so the duplicate-account penalty zeroes my new UID. Could you deregister/blacklist UID 39 or restart validators to clear the cache? Been stuck ~24h. Thank you 🙏 |
|
@anderdc ready for re-review whenever you have a moment — I removed the test as you requested, so this is now just the one-line |
Summary
The all-issues table in
gitt issues listformatted the bounty fill percentage with{fill_pct:.0f}%, which rounds. A bounty funded to 99.5–99.99% therefore rendered as(100%)right next to aRegisteredstatus — a self-contradiction, since an issue only flips toActiveat a true 100% (fill_pct >= 100is a separate branch). A tiny nonzero fill likewise rendered as(0%).The fix uses
.1f, matching the single-issue Panel view (view.py:141) which already formats the same value with one decimal.Before / after —
gitt issues listBefore (two partially-funded bounties):
After:
Related Issues
None.
Type of Change
Testing
test_issues_list_table_fill_percent_is_not_roundedrenders the real command viaCliRunnerand asserts the table shows the fractional percentage (99.6%/0.3%) and never(100%)for a partially-funded bounty. Fails ontestbefore the fix, passes after.ruff+pyrightclean.Checklist