feat: error for win32/ia32 and linux/armv7l downloads of Electron >= 44#399
Draft
claude[bot] wants to merge 1 commit into
Draft
feat: error for win32/ia32 and linux/armv7l downloads of Electron >= 44#399claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
Electron 44 dropped support for 32-bit Windows (win32/ia32) and armv7l Linux. The first releases without these artifacts are v44.0.0-alpha.4 and v45.0.0-nightly.20260714, so requesting them for newer versions previously failed with an unhelpful HTTP 404 from GitHub releases. Throw a descriptive error before attempting the download instead, scoped to official downloads only - custom mirrors may legitimately host their own 32-bit builds. Electron <= 43 (supported until January 2027) and cached artifacts are unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEEZg64JKFrSDAc7u4V4Na
erickzhao
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard, David Sanders · Slack thread
Before
Electron 44 dropped 32-bit Windows (
win32/ia32) and armv7l Linux (linux/armv7l) builds — the first releases without those artifacts arev44.0.0-alpha.4andv45.0.0-nightly.20260714. CallingdownloadArtifactfor, say,win32/ia32on Electron 44+ attempted the download anyway and surfaced a raw, unexplained HTTP 404 from GitHub releases.After
The same call fails fast with a descriptive error before any network request is made:
Unaffected:
44.0.0-alpha.1–alpha.3, and nightlies beforev45.0.0-nightly.20260714)mirrorOptions), which may legitimately host their own 32-bit builds — same scoping as the existingisOfficialLinuxIA32DownloadcheckHow
src/utils.ts: newisOfficialDropped32BitDownload(platform, arch, version, mirrorOptions)mirroring the structure of the existingisOfficialLinuxIA32Download. It compares against44.0.0-alpha.4withsemver.gte(a plain< 44.0.0/>= 44.0.0bound would misclassify the 44 prereleases), and against45.0.0-nightly.20260714for nightly versions, since semver orders-nightlyafter-alphaeven though those nightlies predate the drop.src/index.ts: guard indownloadArtifact, placed after the cache-read short-circuit next to the existing linux/ia32 warning. The existing precedent warns rather than throws, but there the artifact still exists for applicable versions — here the artifact is gone entirely, so this throws a descriptive error instead of letting the download 404.src/types.ts: qualified theia32/armv7larch examples in the JSDoc with "(Electron 43 and earlier)".44.0.0-alpha.4boundary, the nightly boundary, 43.x, custom mirrors, and never-dropped platform/arch combinations, plusdownloadArtifact-level tests for the throw and the mirror/legacy passthroughs.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEEZg64JKFrSDAc7u4V4Na
Generated by Claude Code