Repository navigation
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
4bab7e7 to
e5714ea
Compare
| import type { Filter, ProjectRouting, TimeRange } from '@kbn/es-query'; | ||
| import { stableStringify } from '@kbn/std'; | ||
|
|
||
| /** Compares the original time selection, pinned filters and effective project routing. */ |
There was a problem hiding this comment.
As mentioned in the Discover PR, this key is likely the same for both. It can probably be unified. I’ll take care of it in the next PR, once I’ve finished everything.
|
Pinging @elastic/kibana-dashboards (Team:Dashboards) |
|
Pinging @elastic/kibana-discover (Team:Discover) |
…eplay_cache_integration Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/build_options_list_fetch_body.ts # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/fetch_and_validate.test.ts # src/platform/plugins/shared/controls/public/controls/data_controls/range_slider/has_no_results.ts # src/platform/plugins/shared/controls/public/controls/data_controls/range_slider/min_max.ts
| } | ||
| } | ||
| return searchSessionIdFromURL ?? dataService.search.session.start(); | ||
| return searchSessionIdFromURL ?? startSearchSession(); |
There was a problem hiding this comment.
Severity: P2 (Medium)
Wait for restored controls to publish their initial filters before treating filter emissions as search changes. On return to a dashboard with a selected range slider, fetching unpauses before the slider's filter reaches the dashboard. That initial filter then starts a fresh session, evicting the replay and advancing the time window even though the user changed nothing.
Generated by Libra. React with 👍 or 👎 to give feedback on this comment.
|
something messed up with the last merge/conflict . I put in draft |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsshared async chunks total size
total optimizer output size
warm start memory
workflow yaml validation
Test Failures
History
cc @bartoval |
39b6918 to
6afd8cb
Compare
65268a1 to
4c96da5
Compare
|
|
||
| const previousEntry = this.entries.get(assetId); | ||
| if (previousEntry) { | ||
| if (previousEntry && previousEntry.sessionId !== entry.sessionId) { |
There was a problem hiding this comment.
Severity: P3 (Low)
Re-registering the same session now keeps its cached responses but still resets lastFetched to the registration time. An editor return that re-registers its session after a context mismatch can therefore make the next dashboard visit label old responses as freshly loaded, even though those responses were never fetched again. Preserve the previous timestamp when retaining the same session's responses.
Generated by Libra. React with 👍 or 👎 to give feedback on this comment.
There was a problem hiding this comment.
Reverted, replay_cache.ts is back to main.
4c96da5 to
70f7c24
Compare
Summary
Screencast.From.2026-11-19.14-36-49.mp4
/eseand/esql_asyncshould not appear when data are cached.Options lists still use their own fetching path (I will do as a dedicated PR) . We only align their time window.