Repository navigation
[9.6](backport #8261) ci: allow vault bot to skip Buildkite on workflow-only PRs - #8302
Merged
Merged
Conversation
Add elastic-vault-github-plugin-prod[bot] to the fleet-server pull-requests allowlist so AW sync PRs that only change skippable paths get a successful buildkite/fleet-server status instead of leaving the required check pending. (cherry picked from commit 8ae008e)
2 tasks done
Contributor
Author
|
This pull request is merged. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The vault-bot Buildkite allowlist backport has no active review issues.
No open issues 🎉
What changed in this PR
Backports #8261 to 9.6, allowing vault-bot PRs to receive the required Buildkite status instead of remaining blocked when only skippable files change.
Changes:
- Adds
elastic-vault-github-plugin-prod[bot]to thefleet-serverjob allowlist. - Preserves existing skip rules and status reporting, while allowing normal builds for non-skippable changes.
| File | Description |
|---|---|
.buildkite/pull-requests.json |
Allows the vault bot to participate in the existing Buildkite PR build-or-skip flow. |
Review effort: Balanced
Contributor
|
Dependency review finished without posting an analysis comment. If you expected a review, push a new commit to this pull request (or close and reopen it) to try again. Workflow run: https://github.com/elastic/fleet-server/actions/runs/44556482025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
oblt-aw sync PRs from
elastic-vault-github-plugin-prod[bot]often change only.github/workflows/trigger-*-aw-*files. Those paths are already covered byskip_ci_on_only_changed, but the vault bot was not on thefleet-serverjob allowlist, so the Buildkite PR bot never ran. Branch protection still requiresbuildkite/fleet-server, so the check stayed pending and blocked merge (for example #8229).What is the problem this PR solves?
Vault-bot PRs that only touch skippable paths (including AW trigger workflows) never received a
buildkite/fleet-serverstatus, so required checks blocked merge even though a full Buildkite run was not needed.How does this PR solve the problem?
Adds
elastic-vault-github-plugin-prod[bot]to thefleet-serverjoballowed_listin.buildkite/pull-requests.json(same bot already allowed on the package and perf-test jobs). Withset_commit_status: true, the PR bot can skip CI for those path-only changes and post a successfulbuildkite/fleet-serverstatus.How to test this PR locally
.github/workflows/trigger-*-aw-*(or otherskip_ci_on_only_changedpaths).buildkite/fleet-serverreports success with a skip message such as "No changes required CI. Skipped." and that a full pipeline did not run.Design Checklist
Not applicable for a Buildkite PR-bot allowlist change.
Checklist
skip-changelog(CI-only)Related issues
This is an automatic backport of pull request ci: allow vault bot to skip Buildkite on workflow-only PRs #8261 done by Mergify.