Skip to content

[9.6](backport #8261) ci: allow vault bot to skip Buildkite on workflow-only PRs - #8302

Merged
fr4nc1sc0-r4m0n merged 1 commit into
9.6from
mergify/bp/9.6/pr-8261
Nov 19, 2026
Merged

fr4nc1sc0-r4m0n merged 1 commit into
9.6from
mergify/bp/9.6/pr-8261

Conversation

@mergify

@mergify mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Motivation

oblt-aw sync PRs from elastic-vault-github-plugin-prod[bot] often change only .github/workflows/trigger-*-aw-* files. Those paths are already covered by skip_ci_on_only_changed, but the vault bot was not on the fleet-server job allowlist, so the Buildkite PR bot never ran. Branch protection still requires buildkite/fleet-server, so the check stayed pending and blocked merge (for example #8229).

What is the problem this PR solves?

Vault-bot PRs that only touch skippable paths (including AW trigger workflows) never received a buildkite/fleet-server status, so required checks blocked merge even though a full Buildkite run was not needed.

How does this PR solve the problem?

Adds elastic-vault-github-plugin-prod[bot] to the fleet-server job allowed_list in .buildkite/pull-requests.json (same bot already allowed on the package and perf-test jobs). With set_commit_status: true, the PR bot can skip CI for those path-only changes and post a successful buildkite/fleet-server status.

How to test this PR locally

  1. Merge this PR.
  2. Open or update a vault-bot PR that only changes files under .github/workflows/trigger-*-aw-* (or other skip_ci_on_only_changed paths).
  3. Confirm buildkite/fleet-server reports success with a skip message such as "No changes required CI. Skipped." and that a full pipeline did not run.
  4. Confirm a vault-bot PR that changes Go or other non-skippable files still triggers a normal Buildkite build.

Design Checklist

Not applicable for a Buildkite PR-bot allowlist change.

Checklist

  • I have made corresponding changes to the documentation — N/A (CI config only)
  • Changelog skipped via skip-changelog (CI-only)

Related issues

Add elastic-vault-github-plugin-prod[bot] to the fleet-server
pull-requests allowlist so AW sync PRs that only change skippable
paths get a successful buildkite/fleet-server status instead of
leaving the required check pending.

(cherry picked from commit 8ae008e)
@mergify
mergify Bot requested a review from a team as a code owner November 19, 2026 15:35
@mergify mergify Bot added the backport label Nov 19, 2026
@mergify
mergify Bot requested review from samuelvl and removed request for a team November 19, 2026 15:35
@mergify mergify Bot added the backport label Nov 19, 2026
@mergify
mergify Bot requested review from a team and a balanced review from Copilot November 19, 2026 15:35
@mergify

mergify Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

This pull request is merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The vault-bot Buildkite allowlist backport has no active review issues.

No open issues 🎉

What changed in this PR

Backports #8261 to 9.6, allowing vault-bot PRs to receive the required Buildkite status instead of remaining blocked when only skippable files change.

Changes:

  • Adds elastic-vault-github-plugin-prod[bot] to the fleet-server job allowlist.
  • Preserves existing skip rules and status reporting, while allowing normal builds for non-skippable changes.
File Description
.buildkite/​pull-requests.json Allows the vault bot to participate in the existing Buildkite PR build-or-skip flow.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Dependency review finished without posting an analysis comment.

If you expected a review, push a new commit to this pull request (or close and reopen it) to try again.

Workflow run: https://github.com/elastic/fleet-server/actions/runs/44556482025

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n merged commit ab3db8d into 9.6 Nov 19, 2026
86 checks passed
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n deleted the mergify/bp/9.6/pr-8261 branch November 19, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants