Skip to content

[8.19](backport #8247) chore(deps): update Go to 1.27.4 - #8285

Merged
andrzej-stencel merged 4 commits into
8.19from
mergify/bp/8.19/pr-8247
Nov 20, 2026
Merged

andrzej-stencel merged 4 commits into
8.19from
mergify/bp/8.19/pr-8247

Conversation

@mergify

@mergify mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

What is the problem this PR solves?

Fleet Server is on Go 1.26.10. Go 1.27 is the current release, and Go 1.26 loses upstream security support when Go 1.28 ships. The automated bump-golang workflow only moves between patch versions of the current minor, so the move to 1.27 has to be done manually.

How does this PR solve the problem?

  • Bumps .go-version and the go directive in go.mod, dev-tools/go.mod and testing/go.mod to 1.27.4. pkg/api/go.mod stays at 1.25.0 because it is a library.

  • Fixes the one new go vet finding from Go 1.27, which go test also runs: wrapping &es.ErrElastic{} with %w is now flagged because only the value type has the Error method. Test_ErrorResp now passes the pointer as an error value, so it still covers the *es.ErrElastic path that production code uses.

  • Includes the output of mage check:fix (go fix with the Go 1.27 modernizers), which check:ci enforces: errors.As → errors.AsType, atomic.AddUint64 on plain fields → atomic.Uint64, strings.SplitN(...)[0] → strings.Cut, and promoted-field composite literals. These are mechanical and don't change behaviour.

  • Works around an upstream Go 1.27 incompatibility in the TestOpAMPWithUpstreamCollector e2e test. That test builds opentelemetry-collector-contrib from main with this repository's Go version. With Go 1.27 the binary panics on startup (crypto: RegisterHash of unknown hash function). The cause is asapauthextension's dependency github.com/SermoDigital/jose, which registers crypto.Hash(0) (Compiling using go 1.27 results in a binary that panics on startup open-telemetry/opentelemetry-collector-contrib#51868). The test only needs the OpAMP extension, so it now drops asapauthextension from the builder config before building. The workaround can go once upstream fixes the issue.

No other changes were needed:

  • The Docker builds take GO_VERSION from .go-version, and golang:1.27.4-trixie and golang-crossbuild:1.27.4-{main,base-arm}-debian11 are already published.
  • golangci-lint v2.15.0 already supports Go 1.27 (support was added in v2.13.0).
  • The bump-golang updatecli job reads the minor version from .go-version, so it will follow 1.27.x from here.

Lint fixes (separate commit): the lint job runs with --whole-files, so the go fix rewrites surfaced 54 pre-existing findings (52 goconst, 2 gosec) in the touched files. The last commit fixes them without changing behaviour:

  • Repeated literals become constants with the same values, reusing existing ones (file.Field*, the t* integration-test constants, kElasticsearch) where they exist.
  • Two copy-pasted case names in TestChunkMarksFinal are renamed to say what the test checks.
  • The gosec findings were false positives on test data and on an error name, so they get nolint directives that explain why.

golangci-lint v2.15.0, run the same way as CI, now reports 0 issues.

Unrelated, noticed while doing this: uploader.ErrInvalidUploadID responds with the error name ErrAPIKeyNotFound, which looks like a copy-paste mistake. I left the value unchanged because changing it would change the API response.

Backports: labelled backport-active-all, like the 1.26 bump (#6800). The automatic backports will probably conflict in the go fix files, because those have drifted on the release branches. Every branch needs the version files, the changelog fragment and the error_test.go vet fix. 9.5 and 9.6 run go fix in CI, so their backports should re-run mage check:fix on the branch. 8.19 and 9.4 don't, so they can drop the go fix changes. The lint-fix commit is optional on every branch.

How to test this PR locally

mage check:ci
mage test:unit
go vet -tags=integration ./...

Locally:

  • mage test:unit passes with the race detector.
  • go vet reports nothing new under any build tag, in either module.
  • Re-running generate, check:imports, check:fix, check:headers and check:notice produces no diff.

Design Checklist

Not applicable: this is a toolchain bump with no runtime design change.

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

🤖 Generated with Claude Code


This is an automatic backport of pull request #8247 done by [Mergify](https://mergify.com).

* Update Go to 1.27.4

Bump the Go version from 1.26.10 to 1.27.4 in .go-version and the
go.mod files of the main, dev-tools and testing modules. pkg/api keeps
its lower go directive since it is a library.

Go 1.27 changes required alongside the bump:
- go vet now reports wrapping a pointer with %w when only the value type
  has the Error method. Pass the error in Test_ErrorResp as an error
  interface value so the test keeps exercising *es.ErrElastic.
- Apply the output of `mage check:fix` (go fix with the Go 1.27
  modernizers), which CI enforces: errors.AsType, atomic.Uint64,
  strings.Cut and promoted-field composite literals. No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Fix golangci-lint findings in files touched by the Go 1.27 update

The lint job runs with --whole-files, so the go fix rewrites surfaced
existing goconst and gosec findings in every touched file. Fix them
without changing behaviour:

- Replace repeated literals with constants of the same value, reusing
  existing ones where they exist (file.Field*, the t* integration test
  constants, kElasticsearch) and adding named constants for HTTP error
  names, upload document fields, the ack response action and the APM
  error.type value.
- Use testNamespace in the namespaces integration test where the
  literal was repeated.
- Rename two copy-pasted case names in TestChunkMarksFinal so they
  describe what the test checks.
- Annotate three gosec G101/G117 false positives on test data and an
  error name with explained nolint directives.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Drop asapauthextension from the upstream collector e2e build

TestOpAMPWithUpstreamCollector builds opentelemetry-collector-contrib
from main with the repository's Go version. With Go 1.27 the resulting
binary panics on startup: asapauthextension depends on
github.com/SermoDigital/jose, which registers crypto.Hash(0) in an init
function, and Go 1.27's crypto.RegisterHash panics on that
(open-telemetry/opentelemetry-collector-contrib#51868).

The test only needs the OpAMP extension, so remove asapauthextension
from the builder config before building, until upstream is fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Apply go fix to tests merged from main

#8091 added test code that Go 1.27's go fix rewrites (promoted-field
composite literals), which made check:ci fail after main was merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Borja Aranda <me@fbac.dev>
(cherry picked from commit a937df3)

# Conflicts:
#	internal/pkg/api/error.go
#	internal/pkg/api/error_test.go
#	internal/pkg/api/handleAck_test.go
#	internal/pkg/api/handleCheckin_test.go
#	internal/pkg/api/handleEnroll_test.go
#	internal/pkg/api/handleFileDelivery_test.go
#	internal/pkg/api/handleOpAMP.go
#	internal/pkg/api/handleOpAMP_test.go
#	internal/pkg/file/delivery/delivery_test.go
#	internal/pkg/file/es.go
#	internal/pkg/file/es_test.go
#	internal/pkg/file/uploader/finalize_test.go
#	internal/pkg/file/uploader/upload.go
#	internal/pkg/file/uploader/upload_test.go
#	internal/pkg/policy/monitor_test.go
#	internal/pkg/policy/policy_output_test.go
#	internal/pkg/server/integration_consts_test.go
#	internal/pkg/server/namespaces_integration_test.go
#	internal/pkg/server/remote_es_output_integration_test.go
#	internal/pkg/testing/es_helpers.go
#	testing/e2e/scaffold/scaffold.go
#	testing/e2e/stand_alone_test.go
@mergify
mergify Bot requested a review from a team as a code owner November 19, 2026 07:27
@mergify mergify Bot added backport conflicts There is a conflict in the backported pull request labels Nov 19, 2026
@mergify
mergify Bot removed the request for review from a team November 19, 2026 07:27
@mergify mergify Bot added backport conflicts There is a conflict in the backported pull request labels Nov 19, 2026
@mergify
mergify Bot requested review from samuelvl and a balanced review from Copilot November 19, 2026 07:27
@mergify

mergify Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of a937df3 has failed:

On branch mergify/bp/8.19/pr-8247
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit a937df3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .go-version
	new file:   changelog/fragments/1794821809-Update-Go-to-1.27.4.yaml
	modified:   dev-tools/go.mod
	modified:   go.mod
	modified:   internal/pkg/api/handleAck.go
	modified:   internal/pkg/api/handleAudit.go
	modified:   internal/pkg/api/handleAudit_test.go
	modified:   internal/pkg/api/handleUpload.go
	modified:   internal/pkg/api/handleUpload_test.go
	modified:   internal/pkg/dl/action_results_integration_test.go
	modified:   internal/pkg/dl/enrollment_api_key_integration_test.go
	modified:   internal/pkg/es/result_test.go
	modified:   internal/pkg/logger/http.go
	modified:   internal/pkg/policy/self_test.go
	modified:   internal/pkg/server/fleet_integration_test.go
	modified:   internal/pkg/testing/actions.go
	modified:   testing/go.mod

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   internal/pkg/api/error.go
	both modified:   internal/pkg/api/error_test.go
	both modified:   internal/pkg/api/handleAck_test.go
	both modified:   internal/pkg/api/handleCheckin_test.go
	both modified:   internal/pkg/api/handleEnroll_test.go
	both modified:   internal/pkg/api/handleFileDelivery_test.go
	deleted by us:   internal/pkg/api/handleOpAMP.go
	deleted by us:   internal/pkg/api/handleOpAMP_test.go
	both modified:   internal/pkg/file/delivery/delivery_test.go
	both modified:   internal/pkg/file/es.go
	both modified:   internal/pkg/file/es_test.go
	deleted by us:   internal/pkg/file/uploader/finalize_test.go
	both modified:   internal/pkg/file/uploader/upload.go
	both modified:   internal/pkg/file/uploader/upload_test.go
	both modified:   internal/pkg/policy/monitor_test.go
	both modified:   internal/pkg/policy/policy_output_test.go
	deleted by us:   internal/pkg/server/integration_consts_test.go
	both modified:   internal/pkg/server/namespaces_integration_test.go
	both modified:   internal/pkg/server/remote_es_output_integration_test.go
	deleted by us:   internal/pkg/testing/es_helpers.go
	both modified:   testing/e2e/scaffold/scaffold.go
	both modified:   testing/e2e/stand_alone_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify

mergify Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

This pull request is merged.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Dependency Update Analysis

Summary: This PR updates the Go toolchain pin from 1.26.11 to 1.27.4 across Fleet Server modules; overall risk is low-to-moderate and compatible with current repository usage.

Dependency 1: Go toolchain 1.26.11 → 1.27.4

Ecosystem: Go

Check Result
Breaking changes ✅ None found for current repo usage
Testable in PR ✅ Yes — .github/workflows/golangci-lint.yml runs on pull_request and uses .go-version
Changelog highlights (`1.26.11` → `1.27.4`)
  • Upstream GitHub release-note body was unavailable via MCP (golang/go has no matching GitHub releases for go1.27.4), so analysis used local metadata.
  • PR commit message documents required compatibility adjustments for Go 1.27 (vet/gofix/lint-related modernizations) and a test-only workaround for upstream collector panic behavior.
  • No CVE/GHSA identifiers were present in available local metadata for this bump.
Usage in this repository
  • Version pins updated in:
    • .go-version:1
    • go.mod:3
    • dev-tools/go.mod:3
    • testing/go.mod:3
  • CI/workflow usage of .go-version:
    • .github/workflows/golangci-lint.yml:32-34 (pull_request, actions/setup-go with go-version-file)
    • .github/workflows/post-dependency-update.yml:22-24 (push to dependency-update branches)
Compatibility assessment
  • This is a Go minor train bump (1.26 → 1.27), not a Go module major-version import-path change.
  • Repository changes in this PR already adapt touched code/tests to Go 1.27 toolchain behavior.
  • No evidence of removed APIs or required config changes affecting current Fleet Server usage patterns.
  • Security posture appears unchanged/slightly improved (newer toolchain), with no identified newly introduced attack surface from available evidence.

Labels Applied

  • oblt-aw/ai/merge-ready — applied (risk low-to-moderate, no repo-impacting breaking changes identified, PR-testable path present).

What is this? | From workflow: Observability Agentic Workflow — Pull Request

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Automerge skipped

Automerge skipped this pull request because the all-files collection is not enabled for this repository.

To allow automerge for this kind of update, enable the matching collection under Automerge on the Control Plane Dashboard (the oblt-aw/dashboard issue). See Automerge dependency collections for what each collection covers.

See Opt in or opt out for how to enable or disable Automerge collections on the Control Plane Dashboard.

Collections currently enabled for automerge: github-actions, pre-commit, updatecli, vm-images

Changed files considered:

  • .buildkite/pipeline.yml
  • .go-version
  • changelog/fragments/1794821809-Update-Go-to-1.27.4.yaml
  • dev-tools/go.mod
  • docs/fips.md
  • go.mod
  • internal/pkg/api/error_test.go
  • magefile.go
  • testing/go.mod

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved merge conflicts and incompatible backported code leave production packages and test suites unable to compile.

13 open issues
What changed in this PR

Backports #8247 to Fleet Server 8.19 to update the Go toolchain to 1.27.4. Alongside the version bump, the patch includes code modernizations, lint cleanup, and newer-branch handler and test additions.

Changes:

  • Updates the toolchain pin and three module directives, with a changelog entry.
  • Modernizes error matching, atomic counters, string splitting, and composite literals; extracts shared constants.
  • Includes OpAMP collector compatibility changes and additional policy, enrollment, and file-transfer tests.
File Description
testing/​go.mod Updates the testing module to Go 1.27.4.
testing/​e2e/​stand_alone_test.go Adds collector and unenrollment tests, including the upstream collector workaround.
testing/​e2e/​scaffold/​scaffold.go Changes Toxiproxy setup and retry handling.
internal/​pkg/​testing/​es_helpers.go Adds Elasticsearch API-key verification helpers.
internal/​pkg/​testing/​actions.go Simplifies action fixture initialization.
internal/​pkg/​server/​remote_es_output_integration_test.go Updates remote-output fixtures, constants, and key splitting.
internal/​pkg/​server/​namespaces_integration_test.go Updates namespace fixtures and shared constants.
internal/​pkg/​server/​integration_consts_test.go Defines shared integration-test constants.
internal/​pkg/​server/​fleet_integration_test.go Modernizes DNS error matching.
internal/​pkg/​policy/​self_test.go Simplifies policy and search-result fixtures.
internal/​pkg/​policy/​policy_output_test.go Adds secret-collector and OTLP output tests.
internal/​pkg/​policy/​monitor_test.go Modernizes fixtures and adds revision/dispatch tests.
internal/​pkg/​logger/​http.go Converts byte counters to typed atomics.
internal/​pkg/​file/​uploader/​upload.go Extracts metadata constants and changes size-limit handling.
internal/​pkg/​file/​uploader/​upload_test.go Updates fixtures, constants, and test-case names.
internal/​pkg/​file/​uploader/​finalize_test.go Adds a refresh-before-finalization regression test.
internal/​pkg/​file/​es.go Introduces and uses a chunk-size field constant.
internal/​pkg/​file/​es_test.go Updates chunk-search fixtures and field constants.
internal/​pkg/​file/​delivery/​delivery_test.go Modernizes search-result fixtures.
internal/​pkg/​es/​result_test.go Simplifies action fixture initialization.
internal/​pkg/​dl/​enrollment_api_key_integration_test.go Modernizes fixtures and documents test-data lint exceptions.
internal/​pkg/​dl/​action_results_integration_test.go Simplifies action-result fixtures.
internal/​pkg/​api/​handleUpload.go Modernizes oversized-request error matching.
internal/​pkg/​api/​handleUpload_test.go Simplifies agent and search-result fixtures.
internal/​pkg/​api/​handleOpAMP.go Adds an OpAMP enrollment and status handler.
internal/​pkg/​api/​handleFileDelivery_test.go Updates fixtures and adds range/library delivery tests.
internal/​pkg/​api/​handleEnroll_test.go Updates fixtures and adds enrollment lifecycle tests.
internal/​pkg/​api/​handleAudit.go Extracts a shared request-decoding error message.
internal/​pkg/​api/​handleAudit_test.go Reuses constants and simplifies agent fixtures.
internal/​pkg/​api/​handleAck.go Modernizes error matching and extracts the response action constant.
internal/​pkg/​api/​handleAck_test.go Updates fixtures and adds uninstall acknowledgment cases.
internal/​pkg/​api/​error.go Extracts error constants and updates error handling.
internal/​pkg/​api/​error_test.go Adds shared constants and the wrapped-pointer vet adjustment.
go.mod Updates the main module to Go 1.27.4.
dev-tools/​go.mod Updates developer tooling to Go 1.27.4.
changelog/​fragments/​1794821809-Update-Go-to-1.27.4.yaml Records the toolchain upgrade.
.go-version Pins Go 1.27.4 for builds and tooling.

Review effort: Balanced

Comment thread internal/pkg/api/error.go Resolved
Comment thread internal/pkg/api/handleAck_test.go Resolved
Comment thread internal/pkg/api/handleEnroll_test.go Resolved
Comment thread internal/pkg/api/handleOpAMP.go Resolved
Comment thread internal/pkg/file/uploader/upload.go Resolved
Comment thread internal/pkg/policy/monitor_test.go Resolved
Comment thread testing/e2e/stand_alone_test.go Resolved
@github-actions

This comment has been minimized.

Mergify's cherry-pick of the #8247 squash commit left conflict markers.
Restore every file it touched to this branch's version, then re-apply
what the branch needs for Go 1.27.4:
- .go-version and the go directive in go.mod, dev-tools/go.mod and
  testing/go.mod
- the changelog fragment
- the go vet fix in internal/pkg/api/error_test.go

This branch's check:ci does not run go fix, so the go fix rewrites and
the lint fixes from #8247 are left out. It also has no upstream
collector e2e test, so the asapauthextension workaround is not needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 09:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Dependency Update Analysis

Summary: This PR bumps the Go toolchain from 1.26.11 to 1.27.4 across Fleet Server modules; risk is low-to-moderate and compatible with current usage.

Dependency 1: Go toolchain 1.26.11 → 1.27.4

Ecosystem: Go

Check Result
Breaking changes ✅ None found in repository usage
Testable in PR ✅ Yes — .github/workflows/golangci-lint.yml runs on pull_request with .go-version; note post-dependency-update.yml is push-only automation
Changelog highlights (1.26.11 → 1.27.4)
  • Upstream GitHub Releases for golang/go are unavailable for this version (tag lookups were available, release endpoints returned no matching release body), so detailed upstream release-note text could not be retrieved from MCP.
  • Local commit metadata indicates this bump required a Go 1.27 vet compatibility adjustment in tests (internal/pkg/api/error_test.go) and otherwise keeps behavior unchanged.
  • No CVE/GHSA identifiers were present in the locally available metadata for this PR.
Usage in this repository
  • Version pin changed in .go-version, go.mod, dev-tools/go.mod, and testing/go.mod.
  • Tooling/CI consumers of .go-version include:
    • .github/workflows/golangci-lint.yml (actions/setup-go with go-version-file: .go-version, PR-triggered)
    • .github/workflows/post-dependency-update.yml (actions/setup-go, push-triggered for dependency branches)
    • magefile.go (getGoVersion reads .go-version)
    • .buildkite/scripts/common.sh and .buildkite/hooks/pre-command
    • Makefile (GO_VERSION=$(shell cat '.go-version'))
  • Functional code impact in this PR is test-only (internal/pkg/api/error_test.go), not runtime behavior.
Compatibility assessment
  • This is a minor Go version bump (1.26 → 1.27), not a Go module major-version path change.
  • No dependency API removals/renames are introduced in this PR’s own code changes; modules continue to build against updated Go directives.
  • The only code adjustment addresses stricter vet behavior in Go 1.27 and preserves test intent.
  • Security impact appears neutral-to-improving based on moving to a newer toolchain; no evidence of newly introduced attack surface in repository usage.

Labels Applied

  • oblt-aw/ai/merge-ready (applied): low-to-moderate risk, no repo-usage breaking changes found, and PR-testable CI coverage exists for the primary Go setup workflow.

What is this? | From workflow: Observability Agentic Workflow — Pull Request

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

Both failed jobs are the same configuration/toolchain mismatch: FIPS packaging inherits GOEXPERIMENT=systemcrypto, but Go 1.27.4 rejects that experiment, so go build exits before packaging.

Remediation

  • Clear inherited GOEXPERIMENT in the FIPS build path (for example in Dockerfile.fips after FROM, or in the release wrapper before invoking mage build:release) so Go 1.27 runs with default system-crypto behavior.
  • Re-run the two failing steps: Package x86_64 FIPS and Package aarch64 FIPS.
Investigation details

Root Cause

  • .go-version:1 pins Go 1.27.4.
  • magefile.go:251-257 reads .go-version, and magefile.go:1023 passes it into the Docker builder image tag.
  • Dockerfile.fips:4 and Dockerfile.fips:30 use docker.elastic.co/beats-dev/golang-crossbuild:${GO_VERSION}-${SUFFIX}.
  • In both Buildkite logs, Go fails with:
    • /tmp/gh-aw/buildkite-logs/fleet-server-package-x86_64-fips.txt:121
    • /tmp/gh-aw/buildkite-logs/fleet-server-package-aarch64-fips.txt:121
    • go: GOEXPERIMENT=systemcrypto has been removed...
  • The immediate build failure is at lines 123-125 in both logs (go build ... requirefips and the wrapping docker run ... build:release).

Evidence

Verification

  • Reviewed pre-fetched Buildkite failure summaries and both job logs.
  • Local build/test rerun not performed (workflow is read-only CI triage; DIND unsupported in this runner).

Follow-up

  • I could not verify whether an existing flaky-test issue already tracks this exact failure because issue/comment visibility is partially restricted by the current integrity policy in this run.

What is this? | From workflow: Observability Agentic Workflow — Status

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

The FIPS package jobs failed with:

  go: GOEXPERIMENT=systemcrypto has been removed; system crypto is
  enabled automatically on supported platforms and can be disabled with
  MS_GO_NOSYSTEMCRYPTO=1

microsoft/go 1.27 enables system crypto by default and rejects the
experiment. Stop setting it in the magefile and in the fips140=on unit
test step. Binaries built this way record microsoft_systemcrypto=1
instead of GOEXPERIMENT=systemcrypto, so checkFIPSBinary now checks for
that setting. The binary still links OpenSSL and has
DefaultGODEBUG=fips140=on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The FIPS migration relies on Microsoft Go 1.27 enabling system crypto and emitting microsoft_systemcrypto=1, but release artifacts and provider-backed startup remain unverified with the actual toolchain and crossbuild images.

No open issues 🎉

Review effort: Balanced

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Dependency Update Analysis

Summary: This PR updates the Go toolchain from 1.26.11 to 1.27.4; overall risk is low-to-moderate (safe to merge) with no repo-breaking usage changes found.

Go toolchain 1.26.11 → 1.27.4

Ecosystem: Go

Check Result
Breaking changes ✅ None found in this repo’s consumed usage
Testable in PR ✅ Yes (PR-triggered lint/workflow coverage exists)
Changelog highlights (1.26.11 → 1.27.4)
  • Upstream GitHub release notes were unavailable via MCP (golang/go has no matching Releases endpoint entries for these tags), so analysis used local PR metadata and diff.
  • Toolchain/go directive bumped to 1.27.4 in .go-version, go.mod, dev-tools/go.mod, and testing/go.mod.
  • FIPS build handling updated for microsoft/go 1.27+ (GOEXPERIMENT=systemcrypto removed; microsoft_systemcrypto=1 build-setting validation added).
  • One Go 1.27 vet-related test adjustment in internal/pkg/api/error_test.go (%w wrapping via error(&es.ErrElastic{})).
  • No CVE/GHSA identifiers were present in available metadata; no new exposed runtime surface was introduced by these changes.
Usage in this repository
  • Version source: .go-version.
  • Module directives: go.mod, dev-tools/go.mod, testing/go.mod.
  • Consumers of .go-version: Buildkite hooks/scripts (.buildkite/hooks/pre-command, .buildkite/scripts/common.sh), Mage (magefile.go), Makefile, and GitHub workflows (.github/workflows/golangci-lint.yml, .github/workflows/post-dependency-update.yml).
  • FIPS-specific behavior aligned in magefile.go, .buildkite/pipeline.yml, and docs/fips.md.
Compatibility assessment
  • This is a minor Go toolchain update, not a Go module major-version/import-path change.
  • No dependency API removals impacting production code were found; changes are build/test/tooling alignment for Go 1.27 behavior.
  • PR testability is sufficient for this scope (PR-triggered lint workflow uses .go-version); one push-only automation workflow (post-dependency-update) is bot-branch maintenance and does not increase production runtime risk for this PR.

Labels Applied

  • oblt-aw/ai/merge-ready (applied): overall risk is low-to-moderate, no breaking repo usage found, and ecosystem checks for this Go bump pass.

What is this? | From workflow: Observability Agentic Workflow — Pull Request

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@andrzej-stencel
andrzej-stencel enabled auto-merge (squash) November 19, 2026 13:45
@andrzej-stencel
andrzej-stencel enabled auto-merge (squash) November 19, 2026 13:45
golangci-lint (goconst) flags the test literals repeated in Test_ErrorResp
now that the Go 1.27 vet fix touches this file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 13:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The FIPS changes depend on Microsoft Go 1.27.4’s system-crypto defaults and new build-info marker, requiring provider-backed tests and packaged-binary validation on amd64 and arm64 that cannot be performed in this source-only environment.

No open issues 🎉

Review effort: Balanced

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Dependency Update Analysis

Summary: This PR updates the Go toolchain from 1.26.11 → 1.27.4 (repo-wide go directives and .go-version) with low-to-moderate risk; local usage appears compatible and PR-context checks are available.

Go toolchain: 1.26.11 → 1.27.4

Ecosystem: Go

Check Result
Breaking changes ✅ None found in this repo’s consumed usage
Testable in PR ✅ Yes — PR-context checks are running/passing (e.g., lint (linux)), and golangci-lint workflow runs on pull_request
Changelog highlights (1.26.11 → 1.27.4)

Upstream release-note bodies were unavailable via GitHub Releases for golang/go (no matching release objects for go1.27.4 / go1.26.11), so detailed upstream notes could not be extracted from MCP release endpoints.

From local PR metadata/diff, the practical upgrade highlights are:

  • Toolchain bump in .go-version and module go directives (go.mod, dev-tools/go.mod, testing/go.mod).
  • Go 1.27 compatibility adjustments in this repo:
    • internal/pkg/api/error_test.go: wrapping *es.ErrElastic adjusted to satisfy newer vet behavior.
    • magefile.go and .buildkite/pipeline.yml: FIPS/system-crypto handling updated for microsoft/go 1.27+ (microsoft_systemcrypto setting).

No CVE/GHSA claims are made here because upstream advisory/change-note bodies were not available from the release endpoints.

Usage in this repository

Primary usage is toolchain-level (not a single imported module):

  • Version pins changed at:
    • .go-version:1
    • go.mod:3
    • dev-tools/go.mod:3
    • testing/go.mod:3
  • Consumers of .go-version / Go toolchain configuration include:
    • magefile.go (getGoVersion, Docker build args, FIPS build checks around microsoft_systemcrypto)
    • .github/workflows/golangci-lint.yml (actions/setup-go with go-version-file: .go-version; trigger: pull_request)
    • .github/workflows/post-dependency-update.yml (actions/setup-go for dependency-update branches)
    • .buildkite/scripts/common.sh (gvm $(cat .go-version) and Microsoft Go download URL)
Compatibility assessment
  • This is a minor toolchain upgrade (1.26 → 1.27), so language/tooling behavior can shift; however, the diff already includes the expected compatibility updates (vet/test and microsoft/go FIPS handling).
  • No repo usage was found that indicates a broken API/input contract from this bump.
  • Risk impact:
    • Runtime/product code impact is controlled by existing CI and test paths.
    • Most changed surfaces are build/test/tooling configuration.

Overall assessment: low-to-moderate risk, acceptable for merge with normal CI signal checks.

Labels Applied

  • oblt-aw/ai/merge-ready — applied because risk is low-to-moderate, no repo-specific breaking usage found, and PR-context validation is available.

What is this? | From workflow: Observability Agentic Workflow — Pull Request

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@andrzej-stencel
andrzej-stencel merged commit 56aeaa9 into 8.19 Nov 20, 2026
27 checks passed
@andrzej-stencel
andrzej-stencel deleted the mergify/bp/8.19/pr-8247 branch November 20, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request dependency enhancement New feature or request oblt-aw/ai/merge-ready Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants