Repository navigation
Cover Alerting v2 templates in docs, validation, and asset tests #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
teresaromero
merged 29 commits into
elastic:main
from
shmsr:fix/alerting-v2-template-coverage
Nov 18, 2026
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3f91524
Cover Alerting v2 templates in docs, validation, and asset tests
shmsr a23ad13
Fix Alerting v2 null validation and generated documentation
shmsr 34b405c
Fix alert template README escaping and line endings
shmsr b7a8efd
Make alert README description columns consistent
shmsr d947436
Address Alerting v2 template review feedback
shmsr cc98434
Address review: v2-only table escaping, per-name dual-engine grouping
shmsr 6a634b2
Merge branch 'main' into fix/alerting-v2-template-coverage
shmsr 5082eff
Temporarily pin package-spec#1273 so CI exercises SVR00014.
shmsr e9d467b
Merge branch 'main' into fix/alerting-v2-template-coverage
shmsr bca92bf
Pass the build root through alert-rule README tests.
shmsr c41d88a
Pin package-spec#1273 at 74a8e3f.
shmsr 3918334
Pin package-spec#1273 at 2214c16.
shmsr 00d445d
Pin package-spec#1273 at bcb64f6.
shmsr 87f0cf4
Merge remote-tracking branch 'upstream/main' into fix/alerting-v2-tem…
shmsr 2327440
Check alert rule template support on the Kibana client
shmsr 0e48581
Decode alert rule templates once and pick escaping per layout
shmsr eca73c3
Add a test package with classic and Alerting v2 templates
shmsr f231e97
Move the alert rule template asset-test note to the asset testing HOWTO
shmsr 32fccfe
Use ✅ for engine availability in alert rule template tables
shmsr 46a36f9
Skip packages pinned to a newer stack in zip install tests
shmsr 9c6ccfd
Pin package-spec#1273 at ab2114e.
shmsr 660ab62
Target format_version 3.7.0 in the Alerting v2 fixture.
shmsr 4291f08
Pin package-spec to elastic/package-spec#1273 at 2812f13.
shmsr 1243770
Require the merged package-spec SVR00014 and tidy alert template tests
shmsr fda4e7f
Address Alerting v2 review feedback and snapshot install coverage
shmsr c15df85
Keep snapshot updatecli compatible with pre-merge Makefiles
shmsr 31f5919
Preserve Markdown code spans in alert template descriptions
shmsr 829a5e5
Merge upstream main and resolve dependency conflict
shmsr 090bcc6
Preserve existing Markdown escapes in alert description links
shmsr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this dependency neede to be update on this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 , could this change in go.mod and go.sum be reverted?
It looks like that your code is not using this library, is that right?
If needed, I would prefer to do it in a separate PR.
This dependency is going to be updated once a new package-spec release is published and merged here in elastic-package:
https://github.com/elastic/package-spec/blob/648ef3af92849f5f441adaf8864a617b88cfdd5f/go.mod#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, it is related to the
replacedirective to use a specific package-spec commit.So, if that is the case, we would need to be sure that all these changes are removed once the replace directive is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. These upgrades weren't needed by the code in this PR. They came in through the temporary
replace: the package-spec fork requires newer modules than themainthis branch was based on, sogo mod tidypulled them in.I merged the latest
main(now on package-spec v3.7.0) and rerango mod tidy. Compared tomain:go.modonly adds the temporaryreplaceline.go.sumonly swaps the package-spec entries.The fork's
go.modis identical to package-spec v3.7.0's, so swapping thereplacefor a package-spec release that includes SVR00014 changes only the package-spec lines. I'll make that swap in its own commit before merging.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The temporary pin is gone; this now uses released package-spec v3.7.1. Goldmark is a direct dependency because the README renderer uses it to preserve code spans.