Stop eager loading dependencies in dependency parsing workers#1072
Merged
Stop eager loading dependencies in dependency parsing workers#1072
Conversation
The includes(manifests: :dependencies) call loads all manifests and dependencies for a repository/tag into memory before parse_dependencies runs. This data is never used since parse_dependencies fetches fresh results from the parser API. For repositories with many manifests this eager load can consume several GB of memory.
The includes(manifests: :dependencies) call loads all dependency rows into memory but parse_dependencies never reads them. Keep the manifests eager load since sync_manifest and delete_old_manifests use the loaded collection, but drop the nested :dependencies to avoid loading potentially millions of rows.
andrew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseDependenciesWorker and ParseTagDependenciesWorker used
includes(manifests: :dependencies)which loads all dependency rows into memory. The manifests eager load is needed bysync_manifestanddelete_old_manifests, but the nested:dependenciesload is never read. For repositories with many dependencies this can consume several GB of memory.Changed to
includes(:manifests)to keep the manifests preloaded while avoiding loading dependency rows.