Fixes #2085: Only warn once per workspace#2094
Fixes #2085: Only warn once per workspace#2094thahnen wants to merge 1 commit intoeclipse-wildwebdeveloper:masterfrom
Conversation
|
@thahnen This change would require bumping at least for the Could you please update the PR with the plugin and feature versions bumped at least by Thanks for the contribution! |
|
Hey @vrubezhny, I bumped up the versions! |
|
@vrubezhny, one question regarding the process: Who will be reviewing this and then merging it? Is it done by some specific persons that I have to ping, or is it something else? |
This could be me or @akurtakov as well as any other committer on the project. |
There was a problem hiding this comment.
Pull request overview
This PR addresses #2085 by persisting the “missing/undetermined Node.js” warning state in workspace preferences so users aren’t warned again after restarting Eclipse in the same workspace.
Changes:
- Replace the in-memory “already warned” flag with an
InstanceScope(workspace) preference flag. - Always route missing-node warnings through the preference-backed guard.
- Bump plugin/feature versions to
1.0.9/1.2.6.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| org.eclipse.wildwebdeveloper.embedder.node/src/org/eclipse/wildwebdeveloper/embedder/node/NodeJSManager.java | Persist “already warned” state in workspace prefs and gate warning dialogs accordingly |
| org.eclipse.wildwebdeveloper.embedder.node/pom.xml | Plugin version bump to 1.0.9-SNAPSHOT |
| org.eclipse.wildwebdeveloper.embedder.node/META-INF/MANIFEST.MF | Bundle version bump to 1.0.9.qualifier |
| org.eclipse.wildwebdeveloper.embedder.node.feature/pom.xml | Feature version bump to 1.2.6-SNAPSHOT |
| org.eclipse.wildwebdeveloper.embedder.node.feature/feature.xml | Feature version bump to 1.2.6.qualifier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| private static boolean hasAlreadyWarnedNodeJsMissing() { | ||
| return Platform.getPreferencesService().getBoolean(Activator.PLUGIN_ID, ALREADY_WARNED_NODEJS_MISSING, false, null); |
| return Platform.getPreferencesService().getBoolean(Activator.PLUGIN_ID, ALREADY_WARNED_NODEJS_MISSING, false, null); | ||
| } | ||
|
|
||
| private static void setAlreadyWarnedNodeJsMissing() { | ||
| try { | ||
| IEclipsePreferences workspacePreferences = InstanceScope.INSTANCE.getNode(Activator.PLUGIN_ID); | ||
| workspacePreferences.putBoolean(ALREADY_WARNED_NODEJS_MISSING, true); | ||
| workspacePreferences.flush(); | ||
| } catch (BackingStoreException e) { | ||
| ILog.get().error(e.getMessage(), e); | ||
| } |
No description provided.