[24549] Remove stale tcp channels (backport #6421)#6458
Merged
Conversation
12 tasks
* Refs #24549: Test for removing stale channel_resources_ of finished clients Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24549: Improve TCP clean up Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24549: Ensure proper destruction in test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24549: Protect smart wait from potential data race Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24549: Fix test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 8188b41)
cferreiragonz
force-pushed
the
mergify/bp/3.2.x/pr-6421
branch
from
July 14, 2026 10:18
27f9269 to
bf00638
Compare
cferreiragonz
self-requested a review
July 14, 2026 10:18
cferreiragonz
previously approved these changes
Jul 14, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
July 14, 2026 10:20
cferreiragonz
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces logic to remove stale TCP ACCEPT type channels when the listening operation ends (Asio detects and closes the socket). We can only perform this action on ACCEPT type channels because the re-connection mechanism of the CONNECT type channels rely on detecting stale channels and try to re-establish the connection when data needs to be sent.
@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6421 done by [Mergify](https://mergify.com).