Skip to content

Remove setting of SERIALIZED_MEMBER_SIZE when serializing vector of booleans as array#332

Merged
MiguelCompany merged 2 commits into
masterfrom
bugfix/bool_array
Jul 22, 2026
Merged

Remove setting of SERIALIZED_MEMBER_SIZE when serializing vector of booleans as array#332
MiguelCompany merged 2 commits into
masterfrom
bugfix/bool_array

Conversation

@richiware

@richiware richiware commented Jul 22, 2026

Copy link
Copy Markdown
Member

Description

Although the setting of SERIALIZED_MEMBER_SIZE is wrong in the case of serializing an array of primitives, this line had no effect because SERIALIZED_MEMBER_SIZE is used when the user uses serialize_member. But serialize_bool_array will never be called in that case. Even so this PR removes the line.

@Mergifyio backport 2.3.x 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
richiware requested a review from MiguelCompany July 22, 2026 07:46
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Jul 22, 2026
MiguelCompany
MiguelCompany previously approved these changes Jul 22, 2026

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany
MiguelCompany merged commit 4f983f2 into master Jul 22, 2026
16 checks passed
@MiguelCompany
MiguelCompany deleted the bugfix/bool_array branch July 22, 2026 08:43
@MiguelCompany

Copy link
Copy Markdown
Member

@Mergifyio backport 2.3.x 2.2.x

@mergify

mergify Bot commented Jul 22, 2026

Copy link
Copy Markdown

backport 2.3.x 2.2.x

✅ Backports have been created

Details

richiware added a commit that referenced this pull request Jul 22, 2026
…ooleans as array (#332)

* Fix

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 4f983f2)
richiware added a commit that referenced this pull request Jul 22, 2026
…ooleans as array (#332)

* Fix

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Fix uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit 4f983f2)
MiguelCompany pushed a commit that referenced this pull request Jul 22, 2026
…ooleans as array (#332) (#333)

* Fix



* Fix uncrustify



---------


(cherry picked from commit 4f983f2)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany pushed a commit that referenced this pull request Jul 22, 2026
…ooleans as array (#332) (#334)

* Fix



* Fix uncrustify



---------


(cherry picked from commit 4f983f2)

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does Cdr::serialize_bool_array() need to assign a value to the serialized_member_size_ variable?

2 participants