Remove setting of SERIALIZED_MEMBER_SIZE when serializing vector of booleans as array#332
Merged
Conversation
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
approved these changes
Jul 22, 2026
Member
|
@Mergifyio backport 2.3.x 2.2.x |
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the setting of
SERIALIZED_MEMBER_SIZEis wrong in the case of serializing an array of primitives, this line had no effect becauseSERIALIZED_MEMBER_SIZEis used when the user usesserialize_member. Butserialize_bool_arraywill never be called in that case. Even so this PR removes the line.@Mergifyio backport 2.3.x 2.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist