Making Note.published settable and adding the migration metadata columns - #295
Open
aaronjae22 wants to merge 2 commits into
Open
aaronjae22 wants to merge 2 commits into
aaronjae22 wants to merge 2 commits into
Conversation
aaronjae22
changed the title
aaronjae22
marked this pull request as ready for review
September 3, 2026 03:54
lisad
approved these changes
Sep 3, 2026
aaronjae22
force-pushed
the
feat/settable-note-published
branch
from
September 9, 2026 01:12
1dcc855 to
4b0d3fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294
Note.published was auto_now_add=True, which does not merely default the value so Note(published=some_date) was not working properly since it silently discarded the date. That made it impossible for an importer to preserve an object's original publication time, which LOLA §7.1.7 asks for as a SHOULD ("The destination SHOULD keep the 'published' timestamp rather than rewrite it"), since imported content is written through these same models. It also left the content collection ordering on a column where every row shared the same second, so any future cursor-based pagination over -published could skip or repeat rows
Also, Note carried only actor, content, published and visibility, so there was nowhere for the metadata §6.3 names — addressing, reply chain, canonical URL, original markup, breadcrumbs — to be preserved into.