fix(pr): keep .context phase artifacts out of PR diffs#326
Merged
Conversation
The phase protocol wrote ship-{ts}.md (and other phase artifacts) to
.context/phases/ and assumed that directory was gitignored. In repos
that do not gitignore .context/, `git add -A`/`git add .` swept the
artifact into the PR commit — reviewers flagged it, costing an extra
review + force-push cycle.
- phase-protocol.md: replace the "per-worktree and gitignored" assumption
with an explicit rule — never git add/commit phase artifacts; stage only
the real change; gitignore .context/ if a repo needs it tracked.
- pr/SKILL.md: mirror the rule at the ship-{ts}.md step, tied to the
commit steps, with "never git add -A/git add ." guidance.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
…it steps - phase-protocol.md: reword the gitignore fallback to drop the contradictory "genuinely needs .context/ tracked" phrasing (W2); add a "never commit" reminder to the Archive section, which was a latent leak path (W1). - pr/SKILL.md: fix the same wording, correct "above" → "below" cross-ref, and add inline "stage specific files, not git add -A" notes to Step 1 and Step 4b so the commit paths are self-contained (I1, I2). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phase protocol wrote ship-{ts}.md (and other phase artifacts) to .context/phases/ and assumed that directory was gitignored. In repos that do not gitignore .context/, git add -A / git add . swept the artifact into the PR commit — reviewers flagged it, costing an extra review + force-push cycle.
Co-Authored-By: Claude noreply@anthropic.com