Fix local cache not cleared after mutating operations#562
Open
Gardner-Programs wants to merge 1 commit into
Open
Fix local cache not cleared after mutating operations#562Gardner-Programs wants to merge 1 commit into
Gardner-Programs wants to merge 1 commit into
Conversation
…ir, rmtree) Closes drivendataorg#388. After each mutating operation, clear_cache() is now called on affected paths so stale local cache entries don't cause errors on subsequent access. Note: rmdir on Azure and S3 may behave unexpectedly with empty directories since those providers don't persist empty directory objects. This is a pre-existing limitation unrelated to this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #388.
When files or directories are deleted or moved via
unlink,replace,rename,rmdir, orrmtree, the local cache was not being cleared. This caused stale cached files to persist on disk, leading to errors or incorrect data on subsequent access.self.clear_cache()after_removeinunlinkandrmdirself.clear_cache()andtarget.clear_cache()after_move_fileinreplace(renamedelegates toreplaceand gets the fix for free)self.clear_cache()after_removeinrmtreeNote:
rmdiron Azure and S3 may behave unexpectedly with empty directories since those providers don't persist empty directory objects. This is a pre-existing limitation unrelated to this fix.Test plan
test_cache_cleared_after_mutationtotests/test_caching.pycoveringunlink,replace, andrmtreeacross all supported providers