[dotnet-svcutil] Update CustomBinding TransportSecurityBindingElement…#5789
Open
imcarolwang wants to merge 4 commits into
Open
[dotnet-svcutil] Update CustomBinding TransportSecurityBindingElement…#5789imcarolwang wants to merge 4 commits into
imcarolwang wants to merge 4 commits into
Conversation
imcarolwang
force-pushed
the
cumstomBindingCodeGenIssue
branch
from
3d6cb05 to
287ecc6
Compare
5 tasks
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
imcarolwang
force-pushed
the
cumstomBindingCodeGenIssue
branch
from
cf9e3eb to
6de8633
Compare
imcarolwang
force-pushed
the
cumstomBindingCodeGenIssue
branch
from
6de8633 to
89adab3
Compare
…, update baselines - Fix typo in test case name: SspiNegoAuthRequireCancelTokenFasle -> SspiNegoAuthRequireCancelTokenFalse (WSDL, baseline folder, InlineData) - Use .GetType().FullName in error message for consistency with the existing error at line 1084 - Remove unreachable KerberosOverTransport branch: IsKerberosBinding() checks for SymmetricSecurityBindingElement which can never match a TransportSecurityBindingElement parameter. The correct detection method (IsKerberosOverTransportBinding) is #if NO in the framework fork, and EndpointSelector rejects the non-default AlgorithmSuite anyway. Added a comment explaining why Kerberos is not yet supported and what is needed. - Update CertificateAuth and SspiNegoAuthRequireCancelTokenTrue baselines to include ExcludeFromCodeCoverageAttribute (from rebase on latest main). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
imcarolwang
force-pushed
the
cumstomBindingCodeGenIssue
branch
from
89adab3 to
c95fe5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Configuration Generation Fix in PR #4843
This PR builds on the changes from PR #4843, which fixed issues with generating the CustomBinding TransportSecurityBindingElement. It addresses the improvements the original PR author pointed out but hadn't been added yet, and adds some test scenarios to validate the fix.