Show other VMR PRs in codeflow comments - #6748
Open
akoeplinger wants to merge 2 commits into
Open
akoeplinger wants to merge 2 commits into
akoeplinger wants to merge 2 commits into
Conversation
Fixes dotnet#6747 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 121db1fa-a2dc-4abf-b41a-10ebc744f123
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Deduplication can incorrectly reorder PRs when one URI appears in multiple commits.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds contextual VMR pull requests to backflow comments while leaving forward-flow comments unchanged.
Changes:
- Separates path-matching and other PRs.
- Adds a collapsed “Other PRs” section.
- Adds focused grouping and failure tests.
| File | Description |
|---|---|
VmrCodeflower.cs |
Groups and formats PR references. |
VmrCodeFlowerCommentIncludedPRsTests.cs |
Tests filtering, deduplication, formatting, and failures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 121db1fa-a2dc-4abf-b41a-10ebc744f123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the existing VMR PR list and add a collapsed "Other PRs in the commit range" section for additional context. Group PRs by URI so duplicate references cannot appear in both lists. Both forward-flow and backflow lists now show each PR once, retaining its earliest position in the displayed history.
Fixes #6747
Before:
After (list is collapsed by default):
Validation
scripts/verifydid not pass: SQL Server connectivity failures and mock/assertion failures in the broader test suite.