This repository was archived by the owner on Feb 6, 2021. It is now read-only.
remove regex semicolon to allow arrays in call dst_class#6
Open
mobsecteam wants to merge 1 commit into
Open
Conversation
Previously the semicolon before the arrow dictated that the dst_class had to be something that ended with a semicolon, however this is not always the case. You could have a case where an array is used with a primitive type, such as
invoke-virtual {v2}, [J->clone()Ljava/lang/Object;
To account for this, we can just remove the semicolon from the regex so that any dst_class before the -> can be parsed
Owner
|
Hi, thank your for your PR. Your "objection" seems legit. I'll have a look at some examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the semicolon before the arrow dictated that the dst_class had to be something that ended with a semicolon, however this is not always the case. You could have a case where an array is used with a primitive type, such as
invoke-virtual {v2}, [J->clone()Ljava/lang/Object;
To account for this, we can just remove the semicolon from the regex so that any dst_class before the -> can be parsed